Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 789613004: Decision whenever "Allow to collect URL?" bubble should be shown or not (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_url_collection_experiment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index b98f9e7d496500ebd6343c48ccf5c09388142be0..8ed58b0006e4e4610c1d9966fc2cdded198ef9a8 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -154,6 +154,7 @@ bool ChromePasswordManagerClient::IsPasswordManagerEnabledForCurrentPage()
bool ChromePasswordManagerClient::ShouldAskUserToSubmitURL(const GURL& url) {
return url.is_valid() && !url.is_empty() && url.has_host() &&
+ password_manager_.IsSavingEnabledForCurrentPage() &&
password_manager::urls_collection_experiment::ShouldShowBubble(
GetPrefs());
}
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_manager_url_collection_experiment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698