Issue 789603003: Remove candidate tracking bit from <style>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789603003: Remove candidate tracking bit from <style>. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
ojan, eseidel

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove candidate tracking bit from <style>. This bit doesn't really seem to do anything except prevent a hash table lookup in removeChild. I'm hoping to remove the hash tables anyway, so lets just remove this bit. I also removed the dead m_loading bit. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/284045e29d4ba5707f0d5f417325cea4c2f54bac

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	sky/engine/core/html/HTMLStyleElement.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	sky/engine/core/html/HTMLStyleElement.cpp	View		4 chunks	+1 line, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years ago (2014-12-12 02:43:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
284045e29d4ba5707f0d5f417325cea4c2f54bac (presubmit successful).