Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: pkg/analysis_server/test/services/refactoring/extract_method_test.dart

Issue 789543002: Ignore ButtonType when computing an extracted method return type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_method.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/extract_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
index 6ecc3a0cb692136e4897cd3c482dc47a67f94283..6dd4e10e09f9ee9239fde2a96611506c570448fd 100644
--- a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
@@ -1075,6 +1075,24 @@ main() {
});
}
+ test_returnType_statements_nullMix() {
+ indexTestUnit('''
+main(bool p) {
+// start
+ if (p) {
+ return 42;
+ }
+ return null;
+// end
+}
+''');
+ _createRefactoringForStartEndComments();
+ // do check
+ return refactoring.checkInitialConditions().then((_) {
+ expect(refactoring.returnType, 'int');
+ });
+ }
+
test_returnType_statements_void() {
indexTestUnit('''
main() {
« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_method.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698