Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update webcontentsdelegateandroid Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 17bed7fbf401461207400c972c1e4f6892923b55..c93d81f959cb73a83381d52bbec74eb17aace463 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -371,9 +371,16 @@ class CONTENT_EXPORT WebContentsDelegate {
// WebContents will be responsible for showing the fullscreen widget.
virtual bool EmbedsFullscreenWidget() const;
- // Called when the renderer puts a tab into or out of fullscreen mode.
- virtual void ToggleFullscreenModeForTab(WebContents* web_contents,
- bool enter_fullscreen) {}
+ // Called when the renderer puts a tab into fullscreen mode.
+ // |origin| is the origin of the initiating frame inside the |web_contents|.
+ // |origin| can be empty in which case, the |web_contents| last committed
Charlie Reis 2014/12/10 19:22:57 nit: no comma
mlamouri (slow - plz ping) 2014/12/11 16:03:20 Done.
+ // URL's origin should be used.
+ virtual void EnterFullscreenModeForTab(WebContents* web_contents,
+ const GURL& origin) {}
+
+ // Called when the renderer puts a tab out of fullscreen mode.
+ virtual void ExitFullscreenModeForTab(WebContents*) {}
+
virtual bool IsFullscreenForTabOrPending(
const WebContents* web_contents) const;

Powered by Google App Engine
This is Rietveld 408576698