Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make try happy Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 77dfde2cc661e450d043ffe69877d77b305aa3ab..486adef10f27060d3150747a3bc0a2ec2f511ee8 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -302,9 +302,13 @@ class FakeFullscreenDelegate : public WebContentsDelegate {
FakeFullscreenDelegate() : fullscreened_contents_(NULL) {}
~FakeFullscreenDelegate() override {}
- void ToggleFullscreenModeForTab(WebContents* web_contents,
- bool enter_fullscreen) override {
- fullscreened_contents_ = enter_fullscreen ? web_contents : NULL;
+ void EnterFullscreenModeForTab(WebContents* web_contents,
+ const GURL& origin) override {
+ fullscreened_contents_ = web_contents;
+ }
+
+ void ExitFullscreenModeForTab(WebContents* web_contents) override {
+ fullscreened_contents_ = NULL;
}
bool IsFullscreenForTabOrPending(
@@ -1302,8 +1306,8 @@ TEST_F(WebContentsImplTest, NavigationExitsFullscreen) {
EXPECT_FALSE(orig_rvh->IsFullscreen());
EXPECT_FALSE(contents()->IsFullscreenForCurrentTab());
EXPECT_FALSE(fake_delegate.IsFullscreenForTabOrPending(contents()));
- orig_rvh->OnMessageReceived(
- ViewHostMsg_ToggleFullscreen(orig_rvh->GetRoutingID(), true));
+ orig_rfh->OnMessageReceived(
+ FrameHostMsg_ToggleFullscreen(orig_rfh->GetRoutingID(), true));
EXPECT_TRUE(orig_rvh->IsFullscreen());
EXPECT_TRUE(contents()->IsFullscreenForCurrentTab());
EXPECT_TRUE(fake_delegate.IsFullscreenForTabOrPending(contents()));
@@ -1354,8 +1358,8 @@ TEST_F(WebContentsImplTest, HistoryNavigationExitsFullscreen) {
for (int i = 0; i < 2; ++i) {
// Toggle fullscreen mode on (as if initiated via IPC from renderer).
- orig_rvh->OnMessageReceived(
- ViewHostMsg_ToggleFullscreen(orig_rvh->GetRoutingID(), true));
+ orig_rfh->OnMessageReceived(
+ FrameHostMsg_ToggleFullscreen(orig_rfh->GetRoutingID(), true));
EXPECT_TRUE(orig_rvh->IsFullscreen());
EXPECT_TRUE(contents()->IsFullscreenForCurrentTab());
EXPECT_TRUE(fake_delegate.IsFullscreenForTabOrPending(contents()));
@@ -1412,8 +1416,8 @@ TEST_F(WebContentsImplTest, CrashExitsFullscreen) {
EXPECT_FALSE(test_rvh()->IsFullscreen());
EXPECT_FALSE(contents()->IsFullscreenForCurrentTab());
EXPECT_FALSE(fake_delegate.IsFullscreenForTabOrPending(contents()));
- test_rvh()->OnMessageReceived(
- ViewHostMsg_ToggleFullscreen(test_rvh()->GetRoutingID(), true));
+ contents()->GetMainFrame()->OnMessageReceived(FrameHostMsg_ToggleFullscreen(
+ contents()->GetMainFrame()->GetRoutingID(), true));
EXPECT_TRUE(test_rvh()->IsFullscreen());
EXPECT_TRUE(contents()->IsFullscreenForCurrentTab());
EXPECT_TRUE(fake_delegate.IsFullscreenForTabOrPending(contents()));
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698