chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make try happy Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

index 2e9df1149a8b60b789f762a2091a64e461fb969f..eaa65716dc3ce9a5b3dc05f6c8a30f93d0f0e3c9 100644

--- a/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

@@ -38,8 +38,8 @@ IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, MAYBE_NonImmersiveFullscreen) {

// notification before testing the zoom bubble visibility.

scoped_ptr<FullscreenNotificationObserver> waiter(

new FullscreenNotificationObserver());

- browser()->fullscreen_controller()->ToggleFullscreenModeForTab(

- web_contents, true);

+ browser()->fullscreen_controller()->EnterFullscreenModeForTab(

+ web_contents, GURL());

waiter->Wait();

}

ASSERT_FALSE(browser_view->immersive_mode_controller()->IsEnabled());