chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc - Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make try happy Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

index e862fc4a37df73cc7afb4140027adf521fe586e4..8647fa20b65ffc97cd672424246bac9c468908d5 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

@@ -73,8 +73,8 @@ IN_PROC_BROWSER_TEST_F(BrowserNonClientFrameViewAshTest,

// NOTIFICATION_FULLSCREEN_CHANGED is sent asynchronously.

scoped_ptr<FullscreenNotificationObserver> waiter(

new FullscreenNotificationObserver());

- browser()->fullscreen_controller()->ToggleFullscreenModeForTab(

- web_contents, true);

+ browser()->fullscreen_controller()->EnterFullscreenModeForTab(

+ web_contents, GURL());

waiter->Wait();

}

EXPECT_FALSE(browser_view->immersive_mode_controller()->IsEnabled());

@@ -131,8 +131,8 @@ IN_PROC_BROWSER_TEST_F(BrowserNonClientFrameViewAshTest, ImmersiveFullscreen) {

{

scoped_ptr<FullscreenNotificationObserver> waiter(

new FullscreenNotificationObserver());

- browser()->fullscreen_controller()->ToggleFullscreenModeForTab(

- web_contents, true);

+ browser()->fullscreen_controller()->EnterFullscreenModeForTab(

+ web_contents, GURL());

waiter->Wait();

}

EXPECT_TRUE(immersive_mode_controller->IsEnabled());

@@ -158,8 +158,7 @@ IN_PROC_BROWSER_TEST_F(BrowserNonClientFrameViewAshTest, ImmersiveFullscreen) {

{

scoped_ptr<FullscreenNotificationObserver> waiter(

new FullscreenNotificationObserver());

- browser()->fullscreen_controller()->ToggleFullscreenModeForTab(

- web_contents, false);

+ browser()->fullscreen_controller()->ExitFullscreenModeForTab(web_contents);

waiter->Wait();

}