Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 78953003: Add counters for write barriers in optimized code. (Closed)

Created:
7 years, 1 month ago by Michael Starzinger
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Add counters for write barriers in generated code. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=18029

Patch Set 1 #

Patch Set 2 : Include all generated code in measurement. #

Patch Set 3 : Ported partially to ARM and MIPS architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/v8-counters.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Michael Starzinger
7 years, 1 month ago (2013-11-20 20:46:04 UTC) #1
Hannes Payer (out of office)
Can we add these counters to MacroAssembler::RecordWrite?
7 years, 1 month ago (2013-11-21 09:51:07 UTC) #2
Michael Starzinger
Should work, yes. Then they are no longer counting WBs just in optimized code, but ...
7 years, 1 month ago (2013-11-21 14:42:17 UTC) #3
Hannes Payer (out of office)
On 2013/11/21 14:42:17, Michael Starzinger wrote: > Should work, yes. Then they are no longer ...
7 years, 1 month ago (2013-11-21 14:55:53 UTC) #4
Michael Starzinger
Done. PTAL.
7 years, 1 month ago (2013-11-21 20:38:44 UTC) #5
Hannes Payer (out of office)
LGTM, should we add it for arm as well?
7 years, 1 month ago (2013-11-21 20:58:40 UTC) #6
Michael Starzinger
There is a shortage of scratch registers on ARM for this. The IncrementCounter macro could ...
7 years, 1 month ago (2013-11-21 21:20:03 UTC) #7
Hannes Payer (out of office)
OK, can be done later on if needed.
7 years, 1 month ago (2013-11-22 07:34:02 UTC) #8
Michael Starzinger
7 years, 1 month ago (2013-11-22 17:37:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r18029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698