Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 789523002: Enable writing layout tests for persistent notifications. (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-sw-contentclient-persistent
Project:
chromium
Visibility:
Public.

Description

Enable writing layout tests for persistent notifications. Layout tests written for persistent notifications will use the existing infrastructure for page notifications. That means that they can be fully interacted with using their regular, Web exposed API, but can also utilize the existing permission plumbing and click simulation made available through the TestRunner. BUG=432527 Committed: https://crrev.com/fcd588f1804bd35550027bcc9e6e5dea4b42e5ee Cr-Commit-Position: refs/heads/master@{#307782}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -36 lines) Patch
M content/shell/browser/layout_test/layout_test_notification_manager.h View 1 2 2 chunks +21 lines, -5 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 2 4 chunks +90 lines, -31 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Peter Beverloo
+mvanouwerkerk for initial review. This depends on the following two CLs: https://codereview.chromium.org/776813004/ https://codereview.chromium.org/728763003/
6 years ago (2014-12-08 18:34:06 UTC) #2
Michael van Ouwerkerk
lgtm
6 years ago (2014-12-08 19:04:11 UTC) #3
Peter Beverloo
+mkwst
6 years ago (2014-12-10 12:15:21 UTC) #5
Peter Beverloo
+avi, asking for your stamp since Mike is out sick. This is plumbing for these ...
6 years ago (2014-12-10 19:34:50 UTC) #7
Avi (use Gerrit)
stampity stamp LGTM
6 years ago (2014-12-10 19:37:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789523002/40001
6 years ago (2014-12-10 19:38:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/6040)
6 years ago (2014-12-10 19:51:32 UTC) #12
Peter Beverloo
On 2014/12/10 19:51:32, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-10 19:54:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789523002/40001
6 years ago (2014-12-10 19:56:03 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-10 22:42:27 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-10 22:43:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fcd588f1804bd35550027bcc9e6e5dea4b42e5ee
Cr-Commit-Position: refs/heads/master@{#307782}

Powered by Google App Engine
This is Rietveld 408576698