Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 789483004: Instrumenting callback of DiskCacheBasedQuicServerInfo::OnIOComplete (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
gavinp, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumenting callback of DiskCacheBasedQuicServerInfo::OnIOComplete. Latest instrumentations show that most of jank comes from DiskCacheBasedQuicServerInfo::OnIOComplete (17.1). Note that it calls DiskCacheBasedQuicServerInfo::DoLoop, which calls a bunch of methods, all of them instrumented now. The above jank happens outside of the DoLoop call, and outside of DiskCacheBasedQuicServerInfo::PersistInternal call. This points to wait_for_ready_callback_ callback. Instrumenting more. (There is also 3.4 jank in Transaction::OnIOComplete, but this is not my focus now.) BUG=422516 Committed: https://crrev.com/e12cac8a794e5f2d34d0253981407c841d44443c Cr-Commit-Position: refs/heads/master@{#307966}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M net/quic/quic_stream_factory.cc View 1 4 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vadimt
gavinp@, please review
6 years ago (2014-12-09 00:48:12 UTC) #2
mmenke
LGTM, rubberstamp
6 years ago (2014-12-11 17:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789483004/1
6 years ago (2014-12-11 18:37:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/103068) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/41848) chromium_presubmit ...
6 years ago (2014-12-11 18:42:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789483004/20001
6 years ago (2014-12-11 19:04:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 20:46:54 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-11 20:47:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e12cac8a794e5f2d34d0253981407c841d44443c
Cr-Commit-Position: refs/heads/master@{#307966}

Powered by Google App Engine
This is Rietveld 408576698