Introduce [Exposed(Arguments)] in IDL code generator.

Source/bindings/scripts/generate_global_constructors.py

 #!/usr/bin/python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates interface properties on global objects.
 
 Concretely these are implemented as "constructor attributes", meaning
 "attributes whose name ends with Constructor" (special-cased by code generator),
 hence "global constructors" for short.
 
 For reference on global objects, see:
 http://heycam.github.io/webidl/#Global
 http://heycam.github.io/webidl/#Exposed
 
 Design document: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import itertools
 import optparse
 import os
 import cPickle as pickle
 import re
 import sys
 
 from collections import defaultdict
-from utilities import get_file_contents, idl_filename_to_interface_name, read_file_to_list, write_file, get_interface_extended_attributes_from_idl, is_callback_interface_from_idl
+from utilities import get_file_contents, idl_filename_to_interface_name, read_file_to_list, write_file, get_interface_extended_attributes_from_idl, get_interface_exposed_arguments, is_callback_interface_from_idl
 
 interface_name_to_global_names = {}
 global_name_to_constructors = defaultdict(list)
 
 
 HEADER_FORMAT = """// Stub header file for {{idl_basename}}
 // Required because the IDL compiler assumes that a corresponding header file
 // exists for each IDL file.
 """
 
@@ skipping 40 matching lines @@
     # http://heycam.github.io/webidl/#es-interfaces
     if (is_callback_interface_from_idl(idl_file_contents) or
         'NoInterfaceObject' in extended_attributes):
         return
 
     # The [Exposed] extended attribute MUST take an identifier list. Each
     # identifier in the list MUST be a global name. An interface or interface
     # member the extended attribute applies to will be exposed only on objects
     # associated with ECMAScript global environments whose global object
     # implements an interface that has a matching global name.
     exposed_global_names = extended_attributes.get('Exposed', 'Window').strip('()').split(',')

[Jens Widell, 2014/12/09 11:30:31]

You could move this line down to line 101 (in the else branch), and change the
condition on line 92 would then just be "if exposed_arguments is not None:".

[yhirano, 2014/12/09 11:59:13]

Done.

-    new_constructors_list = generate_global_constructors_list(interface_name, extended_attributes)
-    for exposed_global_name in exposed_global_names:
-        global_name_to_constructors[exposed_global_name].extend(new_constructors_list)
+
+    exposed_arguments = get_interface_exposed_arguments(idl_file_contents)
+    if exposed_global_names == ['Window'] and exposed_arguments is not None:
+        for argument in exposed_arguments:
+            if 'RuntimeEnabled' in extended_attributes:
+                raise ValueError('RuntimeEnabled should not be used with Exposed(Arguments)')
+            attributes = extended_attributes.copy()
+            attributes['RuntimeEnabled'] = argument['runtime_enabled']
+            new_constructors_list = generate_global_constructors_list(interface_name, attributes)
+            global_name_to_constructors[argument['exposed']].extend(new_constructors_list)
+    else:
+        new_constructors_list = generate_global_constructors_list(interface_name, extended_attributes)
+        for name in exposed_global_names:
+            global_name_to_constructors[name].extend(new_constructors_list)
 
 
 def generate_global_constructors_list(interface_name, extended_attributes):
     extended_attributes_list = [
             name + '=' + extended_attributes[name]
             for name in 'Conditional', 'PerContextEnabled', 'RuntimeEnabled'
             if name in extended_attributes]
     if extended_attributes_list:
         extended_string = '[%s] ' % ', '.join(extended_attributes_list)
     else:
@@ skipping 70 matching lines @@
         constructors = interface_name_to_constructors(interface_name)
         write_global_constructors_partial_interface(
             interface_name,
             idl_filename,
             constructors,
             options.write_file_only_if_changed)
 
 
 if __name__ == '__main__':
     sys.exit(main())