Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerSet.h

Issue 789433006: [New Multicolumn] Let a spanner's containing block be the multicol container. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Compiling release: paint invalidation state is cleared in the super class anyway. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderMultiColumnSpannerSet.h
diff --git a/Source/core/rendering/RenderMultiColumnSpannerSet.h b/Source/core/rendering/RenderMultiColumnSpannerSet.h
deleted file mode 100644
index 5b110f972e88e30ad7dd4f9965efcef0d6af21b4..0000000000000000000000000000000000000000
--- a/Source/core/rendering/RenderMultiColumnSpannerSet.h
+++ /dev/null
@@ -1,43 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef RenderMultiColumnSpannerSet_h
-#define RenderMultiColumnSpannerSet_h
-
-#include "core/rendering/RenderMultiColumnSet.h"
-
-namespace blink {
-
-// "Column" set for column-span:all elements. Positions the portion of the flow thread that a
-// spanner takes up. The actual renderer that sets column-span all is laid out as part of flow
-// thread layout (although it cannot use the flow thread width when calculating its own with; it has
-// to pretend that the containing block is the multicol container, not the flow
-// thread). RenderMultiColumnSpannerSet just makes sure that it's positioned correctly among other
-// column sets, within the multicol container.
-//
-// FIXME: should consider not inheriting from RenderMultiColumnSet (but rather from some common base
-// class). Most of what's in RenderMultiColumnSet is of no interest to us.
-class RenderMultiColumnSpannerSet final : public RenderMultiColumnSet {
-public:
- virtual bool isOfType(RenderObjectType type) const override { return type == RenderObjectRenderMultiColumnSpannerSet || RenderMultiColumnSet::isOfType(type); }
-
- static RenderMultiColumnSpannerSet* createAnonymous(RenderMultiColumnFlowThread*, RenderStyle* parentStyle, RenderBox*);
-
- RenderBox* rendererInFlowThread() const { return m_rendererInFlowThread; }
-
-protected:
- virtual bool recalculateColumnHeight(BalancedHeightCalculation) override;
- virtual const char* renderName() const override;
-
-private:
- RenderMultiColumnSpannerSet(RenderMultiColumnFlowThread*, RenderBox*);
-
- RenderBox* m_rendererInFlowThread; // The actual column-span:all renderer inside the flow thread.
-};
-
-DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMultiColumnSpannerSet, isRenderMultiColumnSpannerSet());
-
-} // namespace blink
-
-#endif
« no previous file with comments | « Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698