[New Multicolumn] Let a spanner's containing block be the multicol container.

Source/core/rendering/RenderMultiColumnFlowThread.h

Index: Source/core/rendering/RenderMultiColumnFlowThread.h
diff --git a/Source/core/rendering/RenderMultiColumnFlowThread.h b/Source/core/rendering/RenderMultiColumnFlowThread.h
index 3e02d85e10e5c5a21010871cdeb0d26625581e8d..8efda225e196eeb78ca1ab7449bb4fe10d516b30 100644
--- a/Source/core/rendering/RenderMultiColumnFlowThread.h
+++ b/Source/core/rendering/RenderMultiColumnFlowThread.h
@@ -28,12 +28,11 @@
 #define RenderMultiColumnFlowThread_h
 
 #include "core/rendering/RenderFlowThread.h"
-#include "wtf/HashMap.h"
 
 namespace blink {
 
 class RenderMultiColumnSet;
-class RenderMultiColumnSpannerSet;
+class RenderMultiColumnSpannerPlaceholder;
 
 // Flow thread implementation for CSS multicol. This will be inserted as an anonymous child block of
 // the actual multicol container (i.e. the RenderBlockFlow whose style computes to non-auto
@@ -57,7 +56,9 @@ class RenderMultiColumnSpannerSet;
 // RenderMultiColumnSet. We only need to create multiple sets if there are spanners
 // (column-span:all) in the multicol container. When a spanner is inserted, content preceding it
 // gets its own set, and content succeeding it will get another set. The spanner itself will also
-// get its own set (RenderMultiColumnSpannerSet).
+// get its own placeholder between the sets (RenderMultiColumnSpannerPlaceholder), so that it gets
+// positioned and sized correctly. The column-span:all element is inside the flow thread, but its
+// containing block is the multicol container.
 //
 // The width of the flow thread is the same as the column width. The width of a column set is the
 // same as the content box width of the multicol container; in other words exactly enough to hold
@@ -106,9 +107,34 @@ public:
     RenderMultiColumnSet* firstMultiColumnSet() const;
     RenderMultiColumnSet* lastMultiColumnSet() const;
 
-    // Return the spanner set (if any) that contains the specified renderer. This includes the
-    // renderer for the element that actually establishes the spanner too.
-    RenderMultiColumnSpannerSet* containingColumnSpannerSet(const RenderObject* descendant) const;
+    // Return the first column set or spanner placeholder.
+    RenderBox* firstMultiColumnBox() const
+    {
+        return nextSiblingBox();
+    }
+    // Return the last column set or spanner placeholder.
+    RenderBox* lastMultiColumnBox() const
+    {
+        RenderBox* lastSiblingBox = multiColumnBlockFlow()->lastChildBox();
+        return lastSiblingBox != this ? lastSiblingBox : 0;

[Julien - ping for review, 2014/12/11 19:09:37]

This comparison warrants some explanations as it doesn't match
firstMultiColumnBox.

Also why don't we try the previous child box if that doesn't work?

[mstensho (USE GERRIT), 2014/12/11 21:01:14]

Done.
The flow thread needs to be the first child. If the last child is the flow
thread, it means that we have no column boxes (spanner placeholders or column
sets).

+    }
+    // Return the previous sibling column set or spanner placeholder.
+    static RenderBox* previousSiblingMultiColumnBoxOf(RenderBox* renderer)

[Julien - ping for review, 2014/12/11 19:09:38]

Those are plain weird being static instead of on RenderBox (maybe with an ASSERT
that we are in a flow thread).

[mstensho (USE GERRIT), 2014/12/11 21:01:14]

Indeed. I was afraid to bloat RenderBox too much, but if you like it, fine. :)

Done.

+    {
+        RenderBox* previousBox = renderer->previousSiblingBox();
+        if (previousBox->isRenderFlowThread())
+            return 0;
+        return previousBox;
+    }
+    // Return the next sibling column set or spanner placeholder.
+    static RenderBox* nextSiblingMultiColumnBoxOf(RenderBox* renderer)
+    {
+        return renderer->nextSiblingBox();
+    }
+
+    // Return the spanner placeholder that belongs to the spanner in the containing block chain, if
+    // any. This includes the renderer for the element that actually establishes the spanner too.
+    RenderMultiColumnSpannerPlaceholder* containingColumnSpannerPlaceholder(const RenderObject* descendant) const;
 
     // Populate the flow thread with what's currently its siblings. Called when a regular block
     // becomes a multicol container.
@@ -143,13 +169,14 @@ protected:
 private:
     void calculateColumnCountAndWidth(LayoutUnit& width, unsigned& count) const;
     void createAndInsertMultiColumnSet();
-    void createAndInsertSpannerSet(RenderBox* spanner);
+    void createAndInsertSpannerPlaceholder(RenderBox* spanner);
     virtual bool descendantIsValidColumnSpanner(RenderObject* descendant) const;
 
     virtual const char* renderName() const override;
     virtual void addRegionToThread(RenderMultiColumnSet*) override;
     virtual void willBeRemovedFromTree() override;
     virtual void flowThreadDescendantWasInserted(RenderObject*) override;
+    virtual void flowThreadDescendantWillBeRemoved(RenderObject*) override;
     virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
     virtual void updateLogicalWidth() override;
     virtual void setPageBreak(LayoutUnit offset, LayoutUnit spaceShortage) override;
@@ -158,17 +185,14 @@ private:
     virtual bool addForcedRegionBreak(LayoutUnit, RenderObject* breakChild, bool isBefore, LayoutUnit* offsetBreakAdjustment = 0) override;
     virtual bool isPageLogicalHeightKnown() const override;
 
-    typedef HashMap<const RenderObject*, RenderMultiColumnSpannerSet*> SpannerMap;
-    SpannerMap m_spannerMap;
-
     unsigned m_columnCount; // The used value of column-count
     LayoutUnit m_columnHeightAvailable; // Total height available to columns, or 0 if auto.
     bool m_inBalancingPass; // Set when relayouting for column balancing.
     bool m_needsColumnHeightsRecalculation; // Set when we need to recalculate the column set heights after layout.
     bool m_progressionIsInline; // Always true for regular multicol. False for paged-y overflow.
+    bool m_isBeingEvacuated;
 };
 
 } // namespace blink
 
 #endif // RenderMultiColumnFlowThread_h
-