Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 789433004: Restructure public side of window_manager service (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of window_manager service Instead of having //mojo/services be structured as so: //mojo/services/public/cpp/foo //mojo/services/public/interfaces/foo we would like it to be structured as so: //mojo/services/foo/public/cpp //mojo/services/foo/public/interfaces This CL does that restructuring for the window_manager service. R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/38c8c0f174634c8ca015eed6bcb247fce9017e7d

Patch Set 1 #

Patch Set 2 : Nit #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -100 lines) Patch
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_context.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/window_manager/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/window_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/window_manager/public/interfaces/window_manager.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/window_manager/public/interfaces/window_manager_internal.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M services/view_manager/BUILD.gn View 1 4 chunks +4 lines, -4 lines 0 comments Download
M services/view_manager/connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/view_manager_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_app.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
blundell
Hi Ben, I realized that it's going to be easier to do the individual services ...
6 years ago (2014-12-08 20:21:43 UTC) #2
Ben Goodger (Google)
This approach seems fine to me and you can TBR future like changes to make ...
6 years ago (2014-12-09 18:34:07 UTC) #4
blundell
6 years ago (2014-12-09 19:20:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
38c8c0f174634c8ca015eed6bcb247fce9017e7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698