Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 789363004: WindowManagerApp should recognize gestures (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
Elliot Glaysher, sky
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

WindowManagerApp should recognize gestures This CL teaches WindowManagerApp to recognize gestures and dispatch gesture events. To recognize the gestures, we use ui/gesture_recognizer, which is a port of Android's gesture recognizer. Some of these classes use the term "aura", but they don't actually depend on the Aura system. As part of this CL, I've removed a couple locations that were querying base's command line static. Mojo doesn't use this static and not all window managers have it initialized. R=erg@chromium.org, sky@chromium.og Committed: https://chromium.googlesource.com/external/mojo/+/29fd00acdefa17fcc97679d834dc60fa70a0d141

Patch Set 1 #

Patch Set 2 : build fix #

Total comments: 4

Patch Set 3 : Rename Aura to Impl and add FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -1777 lines) Patch
M mojo/converters/input_events/input_events_type_converters.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M services/window_manager/window_manager_app.h View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 1 2 2 chunks +23 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 2 5 chunks +9 lines, -21 lines 0 comments Download
D ui/events/events.gyp View 1 2 1 chunk +0 lines, -394 lines 0 comments Download
M ui/events/gesture_detection/gesture_config_helper_aura.cc View 1 chunk +1 line, -4 lines 0 comments Download
D ui/events/gestures/gesture_provider_aura.h View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D ui/events/gestures/gesture_provider_aura.cc View 1 2 1 chunk +0 lines, -137 lines 0 comments Download
D ui/events/gestures/gesture_provider_aura_unittest.cc View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
A + ui/events/gestures/gesture_provider_impl.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
A + ui/events/gestures/gesture_provider_impl.cc View 1 2 7 chunks +15 lines, -20 lines 0 comments Download
A + ui/events/gestures/gesture_provider_impl_unittest.cc View 1 2 4 chunks +23 lines, -65 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
D ui/events/gestures/motion_event_aura.h View 1 2 1 chunk +0 lines, -102 lines 0 comments Download
D ui/events/gestures/motion_event_aura.cc View 1 2 1 chunk +0 lines, -287 lines 0 comments Download
D ui/events/gestures/motion_event_aura_unittest.cc View 1 2 1 chunk +0 lines, -423 lines 0 comments Download
A + ui/events/gestures/motion_event_impl.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/events/gestures/motion_event_impl.cc View 1 2 10 chunks +34 lines, -34 lines 0 comments Download
A + ui/events/gestures/motion_event_impl_unittest.cc View 1 2 12 chunks +24 lines, -24 lines 0 comments Download
M ui/gfx/display.cc View 1 2 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-14 00:00:32 UTC) #1
abarth-chromium
5 years, 11 months ago (2015-01-14 00:15:41 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/789363004/diff/20001/mojo/converters/input_events/input_events_type_converters.cc File mojo/converters/input_events/input_events_type_converters.cc (right): https://codereview.chromium.org/789363004/diff/20001/mojo/converters/input_events/input_events_type_converters.cc#newcode150 mojo/converters/input_events/input_events_type_converters.cc:150: } I suspect you need to do some sort ...
5 years, 11 months ago (2015-01-14 00:27:41 UTC) #4
abarth-chromium
https://codereview.chromium.org/789363004/diff/20001/mojo/converters/input_events/input_events_type_converters.cc File mojo/converters/input_events/input_events_type_converters.cc (right): https://codereview.chromium.org/789363004/diff/20001/mojo/converters/input_events/input_events_type_converters.cc#newcode150 mojo/converters/input_events/input_events_type_converters.cc:150: } On 2015/01/14 at 00:27:40, Elliot Glaysher wrote: > ...
5 years, 11 months ago (2015-01-14 00:29:02 UTC) #5
abarth-chromium
PTAL
5 years, 11 months ago (2015-01-14 00:40:53 UTC) #6
Elliot Glaysher
lgtm
5 years, 11 months ago (2015-01-14 00:50:26 UTC) #7
abarth-chromium
5 years, 11 months ago (2015-01-14 01:01:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
29fd00acdefa17fcc97679d834dc60fa70a0d141 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698