tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 789363002: TimelineBasedMeasurement(object) instead of TimelineBasedMeasurement(page_test.PageTest)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 789363002: TimelineBasedMeasurement(object) instead of TimelineBasedMeasurement(page_test.PageTest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update docs. Add PageTest guards. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/web_perf/timeline_based_measurement.py ('K') | « tools/telemetry/telemetry/web_perf/timeline_based_measurement.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 04325a1e8627fde67e8034693c10a9b47fea9cd6..5e07b960228328b654d86bec85e824ee85e53348 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -215,7 +215,8 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_animation=True))

- measurement = tbm_module.TimelineBasedMeasurement()

+ tbm = tbm_module.TimelineBasedMeasurement(tbm_module.Options())

+ measurement = tbm_module.TimelineBasedPageTest(tbm)

results = self.RunMeasurement(measurement, ps,

options=self._options)

@@ -235,7 +236,8 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_slow=True))

- measurement = tbm_module.TimelineBasedMeasurement()

+ tbm = tbm_module.TimelineBasedMeasurement(tbm_module.Options())

+ measurement = tbm_module.TimelineBasedPageTest(tbm)

results = self.RunMeasurement(measurement, ps, options=self._options)

self.assertEquals([], results.failures)

@@ -273,7 +275,8 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):

ps.AddUserStory(TestTimelinebasedMeasurementPage(

ps, ps.base_dir, trigger_jank=True))

- measurement = tbm_module.TimelineBasedMeasurement()

+ tbm = tbm_module.TimelineBasedMeasurement(tbm_module.Options())

+ measurement = tbm_module.TimelineBasedPageTest(tbm)

results = self.RunMeasurement(measurement, ps,

options=self._options)

self.assertEquals(0, len(results.failures))

« tools/telemetry/telemetry/web_perf/timeline_based_measurement.py ('K') | « tools/telemetry/telemetry/web_perf/timeline_based_measurement.py ('k') | no next file » | no next file with comments »