Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 789363002: TimelineBasedMeasurement(object) instead of TimelineBasedMeasurement(page_test.PageTest) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/session_restore.py ('k') | tools/perf/measurements/measurement_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 77068040a32d2b7723879dc8c9f8080c711f3b1f..7e2c79671e1c1f7289f688d23307f74597b36894 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -10,10 +10,9 @@ from telemetry import benchmark
@benchmark.Disabled('win') # crbug.com/416502
class V8GarbageCollectionCases(benchmark.Benchmark):
"""Measure V8 metrics on the garbage collection cases."""
- def CreatePageTest(self, options):
+ def CreateTimelineBasedMeasurementOptions(self):
# TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
# available in the 'benchmark' category.
- return timeline_based_measurement.TimelineBasedMeasurement(
- overhead_level='v8-overhead')
+ return timeline_based_measurement.Options(overhead_level='v8-overhead')
page_set = page_sets.GarbageCollectionCasesPageSet
« no previous file with comments | « tools/perf/benchmarks/session_restore.py ('k') | tools/perf/measurements/measurement_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698