Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 789353004: Host Chrome OS GAIA signin page in webview (Closed)

Created:
5 years, 12 months ago by Dmitry Polukhin
Modified:
5 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Host Chrome OS GAIA signin page in webview Works partially because GAIA cannot send password from webview. BUG=426316 TEST=manual Committed: https://crrev.com/b83b3ed70b11b3c2c9c147d915ef559d9ec9e50c Cr-Commit-Position: refs/heads/master@{#311314}

Patch Set 1 #

Patch Set 2 : remove changes from https://codereview.chromium.org/812513003 #

Total comments: 4

Patch Set 3 : nits fixed #

Patch Set 4 : fixed GAIA reload case #

Total comments: 2

Patch Set 5 : rebase + switch to messages instead of listener interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -7 lines) Patch
M chrome/browser/chromeos/login/startup_utils.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 3 4 5 chunks +35 lines, -5 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 2 3 4 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 3 4 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ui/login/display_manager.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Dmitry Polukhin
PTAL, hosting signin in webview doesn't not fully ready yet but I would like to ...
5 years, 12 months ago (2014-12-24 15:28:49 UTC) #2
dzhioev (left Google)
LGTM with nit https://codereview.chromium.org/789353004/diff/20001/chrome/browser/chromeos/login/startup_utils.h File chrome/browser/chromeos/login/startup_utils.h (right): https://codereview.chromium.org/789353004/diff/20001/chrome/browser/chromeos/login/startup_utils.h#newcode62 chrome/browser/chromeos/login/startup_utils.h:62: // Set enabled state for webview ...
5 years, 12 months ago (2014-12-25 13:28:46 UTC) #3
Dmitry Polukhin
https://codereview.chromium.org/789353004/diff/20001/chrome/browser/chromeos/login/startup_utils.h File chrome/browser/chromeos/login/startup_utils.h (right): https://codereview.chromium.org/789353004/diff/20001/chrome/browser/chromeos/login/startup_utils.h#newcode62 chrome/browser/chromeos/login/startup_utils.h:62: // Set enabled state for webview based signin flow ...
5 years, 12 months ago (2014-12-25 15:53:55 UTC) #4
Dmitry Polukhin
+xiyuan@ for OWNER review chrome/browser/resources/gaia_auth_host/authenticator.js
5 years, 12 months ago (2014-12-25 15:55:50 UTC) #6
xiyuan
LGTM Thank you for driving this. https://codereview.chromium.org/789353004/diff/60001/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): https://codereview.chromium.org/789353004/diff/60001/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode106 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:106: function GaiaAuthHostListener(gaia_screen) { ...
5 years, 12 months ago (2014-12-26 23:06:02 UTC) #7
Dmitry Polukhin
I rebased CL and now it uses events instead of listener interface. https://codereview.chromium.org/789353004/diff/60001/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js ...
5 years, 11 months ago (2015-01-13 18:53:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789353004/80001
5 years, 11 months ago (2015-01-13 18:54:54 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-13 20:00:39 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 20:01:30 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b83b3ed70b11b3c2c9c147d915ef559d9ec9e50c
Cr-Commit-Position: refs/heads/master@{#311314}

Powered by Google App Engine
This is Rietveld 408576698