Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 789353003: Fix CryptAuthApiCallFlow resulting in an error if the server returns an empty string. (Closed)

Created:
6 years ago by Tim Song
Modified:
6 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix CryptAuthApiCallFlow resulting in an error if the server returns an empty string. A protocol buffer message can be serialized to the empty string. Committed: https://crrev.com/ccef7796e0fab4bde07c17e00cfdd0ed8f7956a3 Cr-Commit-Position: refs/heads/master@{#307942}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M components/proximity_auth/cryptauth/cryptauth_api_call_flow.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc View 2 chunks +5 lines, -2 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Tim Song
6 years ago (2014-12-10 23:33:28 UTC) #2
Ilya Sherman
https://codereview.chromium.org/789353003/diff/20001/components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc File components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc (right): https://codereview.chromium.org/789353003/diff/20001/components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc#newcode140 components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc:140: } Please add a new test to provide coverage ...
6 years ago (2014-12-10 23:38:29 UTC) #3
Tim Song
https://codereview.chromium.org/789353003/diff/20001/components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc File components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc (right): https://codereview.chromium.org/789353003/diff/20001/components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc#newcode140 components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc:140: } On 2014/12/10 23:38:29, Ilya Sherman wrote: > Please ...
6 years ago (2014-12-11 00:12:56 UTC) #4
Ilya Sherman
Alrighty, LGTM. Thanks.
6 years ago (2014-12-11 01:17:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789353003/20001
6 years ago (2014-12-11 18:17:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 19:05:36 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-11 19:06:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ccef7796e0fab4bde07c17e00cfdd0ed8f7956a3
Cr-Commit-Position: refs/heads/master@{#307942}

Powered by Google App Engine
This is Rietveld 408576698