Avoid =~ since msysgit bash doesn't support it.

Avoid =~ since msysgit bash doesn't support it.

This uses grep instead.  Note that just grepping for "--force" matches other
things, e.g. "foo--force--foo", but that's a problem with the original code as
well, I think.

BUG=435729
TEST=Run gclient under msysgit bash.  No error should occur.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293340

[Peter Kasting, 2014-12-10 23:09:35]

pkasting@chromium.org changed reviewers:
+ agable@chromium.org

[Peter Kasting, 2014-12-10 23:09:36]

Followup to https://codereview.chromium.org/756233003 .

[chromium-reviews, 2014-12-10 23:11:31]

Drive by: is there a bash set mode to enable it or is it just out of date?

On Wed, Dec 10, 2014, 15:09 null <pkasting@chromium.org> wrote:

> Reviewers: agable,
>
> Message:
> Followup to https://codereview.chromium.org/756233003 .
>
> Description:
> Avoid =~ since msysgit bash doesn't support it.
>
> This uses grep instead.  Note that just grepping for "--force" matches
> other
> things, e.g. "foo--force--foo", but that's a problem with the original code
> as
> well, I think.
>
> BUG=435729
> TEST=Run gclient under msysgit bash.  No error should occur.
>
> Please review this at https://codereview.chromium.org/789353002/
>
> Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files (+1, -1 lines):
>    M update_depot_tools
>
>
> Index: update_depot_tools
> diff --git a/update_depot_tools b/update_depot_tools
> index
> 309871b2df9c6be8b1ef561a547a5e3969c9864a..039f6cdf694554382f3b8894d3fe13
> 44ae77390f
> 100755
> --- a/update_depot_tools
> +++ b/update_depot_tools
> @@ -140,7 +140,7 @@ if [ "X$DEPOT_TOOLS_UPDATE" != "X0" -a
> -e "$base_dir/.svn" ]
>   then
>     # Update the root directory to stay up-to-date with the latest
> depot_tools.
>     BEFORE_REVISION=$(get_svn_revision)
> -  if [[ $* =~ '--force' ]]; then
> +  if echo $* | grep "--force" > /dev/null; then
>       "$SVN" -q revert -R "$base_dir"
>     fi
>     "$SVN" -q up "$base_dir"
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Kasting, 2014-12-10 23:20:02]

On 2014/12/10 23:11:31, chromium-reviews wrote:
> Drive by: is there a bash set mode to enable it or is it just out of date?

Neither.  Apparently msysgit does not ship the libregex library bash uses to
implement =~.  If they were to start including it, it would Just Work.

[chromium-reviews, 2014-12-10 23:22:37]

d'oh! nevermind me then.

On Wed Dec 10 2014 at 3:20:04 PM <pkasting@chromium.org> wrote:

> On 2014/12/10 23:11:31, chromium-reviews wrote:
> > Drive by: is there a bash set mode to enable it or is it just out of
> date?
>
> Neither.  Apparently msysgit does not ship the libregex library bash uses
> to
> implement =~.  If they were to start including it, it would Just Work.
>
> https://codereview.chromium.org/789353002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[agable, 2014-12-10 23:23:26]

LGTM because msys makes me a sad panda.

[Peter Kasting, 2014-12-10 23:26:39]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-12-10 23:27:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789353002/1

[commit-bot: I haz the power, 2014-12-10 23:29:26]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293340