Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 789343003: Cleanup: More override fixes. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
joshualitt, Nico, mtklein, reed2
CC:
reviews_skia.org, bsalomon, Nico
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup: More override fixes. Fixes errors like: ../../src/gpu/GrGeometryProcessor.h:172:25: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual const char* name() const = 0; ^ ../../include/gpu/GrProcessor.h:66:25: note: overridden virtual function is here virtual const char* name() const = 0; BUG=skia:3075 TEST=ninja -C out/Debug skia_lib TBR=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/e3d5c7f5a901a083b818fe628281c39d1281efeb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/gpu/GrGeometryProcessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tfarina
TBRing...
6 years ago (2014-12-18 01:40:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789343003/1
6 years ago (2014-12-18 01:41:47 UTC) #3
Nico
(lgtm)
6 years ago (2014-12-18 01:42:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e3d5c7f5a901a083b818fe628281c39d1281efeb
6 years ago (2014-12-18 01:50:27 UTC) #6
reed2
6 years ago (2014-12-18 02:31:44 UTC) #8
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698