Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 789303002: win gn: Semi-support for non-depot_tools toolchain (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Dirk Pranke, brettw, vyacheslav.chigrin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

win gn: Semi-support for non-depot_tools toolchain I had to set: DEPOT_TOOLS_WIN_TOOLCHAIN=0 GYP_MSVS_OVERRIDE_PATH=C:/Program Files (x86)/Microsoft Visual Studio 12.0 GYP_MSVS_VERSION=2013 WindowsSdkDir=C:/Program Files (x86)/Windows Kits/8.1 then gn gen out\gn --args="is_debug=true cpu_arch=\"x86\"" ninja -C out/gn base worked OK. Further patches welcome to make this less ugly. R=dpranke@chromium.org Committed: https://crrev.com/fa5da3e4e515967d593c3822b1d82f5e844080c5 Cr-Commit-Position: refs/heads/master@{#307791}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/toolchain/win/setup_toolchain.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/vs_toolchain.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
scottmg
6 years ago (2014-12-10 20:02:21 UTC) #2
Dirk Pranke
better than it was before, at least :). lgtm.
6 years ago (2014-12-10 20:36:05 UTC) #3
scottmg
Yeah. We need to pull in quite a bit of gyp code to do it ...
6 years ago (2014-12-10 20:37:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789303002/40001
6 years ago (2014-12-10 20:37:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29507)
6 years ago (2014-12-10 20:52:57 UTC) #8
scottmg
+brettw as build/toolchain is noparent.
6 years ago (2014-12-10 20:55:37 UTC) #10
brettw
lgtm
6 years ago (2014-12-10 22:49:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789303002/40001
6 years ago (2014-12-10 23:01:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-10 23:34:18 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-10 23:35:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fa5da3e4e515967d593c3822b1d82f5e844080c5
Cr-Commit-Position: refs/heads/master@{#307791}

Powered by Google App Engine
This is Rietveld 408576698