Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 789273002: Bump min PNaCl version to 14173. (Closed)

Created:
6 years ago by jvoung (off chromium)
Modified:
6 years ago
CC:
chromium-reviews, Mark Seaborn, Derek Schuff, bradnelson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Bump min PNaCl version to 14173. We are changing the interface between Chrome and one of the PNaCl translator nexes so that it uses the NaCl IRT more (which is a more stable interface). However, this means that we are not testing the old interface between Chrome and the PNaCl translator nexe anymore on the chrome waterfall, so the old interface may get broken. Bump the min PNaCl version to try and get more users onto using the new nexe, which uses the newer interface. The new nexe also brings in a PNaCl translator based on LLVM 3.5, so having that match the SDK (using LLVM 3.5) is better for debugging (developer-only unstable debug metadata has changed between 3.4 and 3.5). BUG= https://code.google.com/p/nativeclient/issues/detail?id=3914 Committed: https://crrev.com/4fc66d88e351e20fa0d55ec3a0308a31cce5870c Cr-Commit-Position: refs/heads/master@{#308030}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 10 (3 generated)
jvoung (off chromium)
6 years ago (2014-12-10 18:36:54 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/789273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc File chrome/browser/component_updater/pnacl/pnacl_component_installer.cc (right): https://codereview.chromium.org/789273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc#newcode68 chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:68: const char kMinPnaclVersion[] = "0.1.0.14173"; As an aside, ...
6 years ago (2014-12-11 19:22:43 UTC) #4
jvoung (off chromium)
https://codereview.chromium.org/789273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc File chrome/browser/component_updater/pnacl/pnacl_component_installer.cc (right): https://codereview.chromium.org/789273002/diff/1/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc#newcode68 chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:68: const char kMinPnaclVersion[] = "0.1.0.14173"; On 2014/12/11 19:22:43, Mark ...
6 years ago (2014-12-11 19:58:39 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years ago (2014-12-11 20:11:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789273002/1
6 years ago (2014-12-11 23:11:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 02:29:56 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 02:30:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fc66d88e351e20fa0d55ec3a0308a31cce5870c
Cr-Commit-Position: refs/heads/master@{#308030}

Powered by Google App Engine
This is Rietveld 408576698