Issue 789253003: Remove dead code

Issue 789253003: Remove dead code (Closed)

Created:
6 years ago by zhaoze.zhou

Modified:
6 years ago

Reviewers:
esprehn

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Remove dead code CustomElementObserver::notifyElementDidFinishParsingChildren is dead code because nothing use it. This cl will remove this code. BUG=440606 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187408

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -30 lines)			Patch
M	Source/core/dom/custom/CustomElementObserver.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/custom/CustomElementObserver.cpp	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/dom/custom/CustomElementUpgradeCandidateMap.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp	View	1	1 chunk	+0 lines, -17 lines	0 comments	Download

Total messages: 9 (2 generated)

esprehn

You should follow the code all the way down, for example you can remove elementDidFinishParsingChildren ...

6 years ago (2014-12-10 18:28:22 UTC) #3

zhaoze.zhou

On 2014/12/10 18:28:22, esprehn wrote: > You should follow the code all the way down, ...

6 years ago (2014-12-10 18:52:51 UTC) #4

zhaoze.zhou

On 2014/12/10 18:52:51, zhaoze.zhou wrote: > On 2014/12/10 18:28:22, esprehn wrote: > > You should ...

6 years ago (2014-12-17 23:02:12 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789253003/40001

6 years ago (2014-12-17 23:05:44 UTC) #8

commit-bot: I haz the power

6 years ago (2014-12-17 23:14:50 UTC) #9

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187408