Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 789253002: Remove MULTILINE, ^, and $ from re finding actual_results.json. (Closed)

Created:
6 years ago by bungeman-skia
Modified:
6 years ago
Reviewers:
stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove MULTILINE, ^, and $ from re finding actual_results.json. MULTILINE, ^, and $ work based on the platform, but the files being parsed are from other platforms. As a result, the current code for extracting the actual_results.json version will not find it in logfiles produced on Windows when run on Mac. The code for extracting the exact actual_results.json file to use from a logfile is itself something of a hack, as this information should be provided ina more structured manner. This proposed method of finding the exact file is no worse than the old one, and in cases like above, better. Committed: https://skia.googlesource.com/skia/+/5bec916cf676bbb2b48b3827d93107c28d770bbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gm/rebaseline_server/download_actuals.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
On Mac '$' matches '\n', but Windows log files end lines with '\r\n' so when ...
6 years ago (2014-12-10 15:37:18 UTC) #2
stephana
On 2014/12/10 15:37:18, bungeman1 wrote: > On Mac '$' matches '\n', but Windows log files ...
6 years ago (2014-12-10 19:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789253002/1
6 years ago (2014-12-10 19:06:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 20:18:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5bec916cf676bbb2b48b3827d93107c28d770bbe

Powered by Google App Engine
This is Rietveld 408576698