Issue 789213002: Extract non-IO part of mksnapshot into an API method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789213002: Extract non-IO part of mksnapshot into an API method. (Closed)

Created:
6 years ago by Yang

Modified:
6 years ago

Reviewers:
vogelheim1, vogelheim

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Extract non-IO part of mksnapshot into an API method. R=vogelheim@chromium.org

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -162 lines)			Patch
M	include/v8.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/mksnapshot.cc	View		4 chunks	+14 lines, -114 lines	0 comments	Download
M	src/snapshot.h	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/snapshot-common.cc	View		3 chunks	+44 lines, -27 lines	0 comments	Download
M	src/snapshot-external.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/snapshot-source-sink.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/snapshot-source-sink.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789213002/20001

6 years ago (2014-12-10 13:53:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001)