Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: chrome/browser/webdata/autofill_table_unittest.cc

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment fix. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/autofill_table.cc ('k') | chrome/browser/webdata/web_database_migration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/autofill_table_unittest.cc
diff --git a/chrome/browser/webdata/autofill_table_unittest.cc b/chrome/browser/webdata/autofill_table_unittest.cc
index ca37e70820ef4edc39546cddfaf4c2492f33f424..4b2e61e6029956564f30cdc11f08a01d7254a9bd 100644
--- a/chrome/browser/webdata/autofill_table_unittest.cc
+++ b/chrome/browser/webdata/autofill_table_unittest.cc
@@ -559,7 +559,6 @@ TEST_F(AutofillTableTest, AutofillProfile) {
home_profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("90025"));
home_profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"));
home_profile.SetInfo(PHONE_HOME_WHOLE_NUMBER, ASCIIToUTF16("18181234567"));
- home_profile.SetInfo(PHONE_FAX_WHOLE_NUMBER, ASCIIToUTF16("1915243678"));
Time pre_creation_time = Time::Now();
EXPECT_TRUE(db.GetAutofillTable()->AddAutofillProfile(home_profile));
@@ -640,7 +639,6 @@ TEST_F(AutofillTableTest, AutofillProfile) {
billing_profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("10011"));
billing_profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("United States"));
billing_profile.SetInfo(PHONE_HOME_WHOLE_NUMBER, ASCIIToUTF16("18181230000"));
- billing_profile.SetInfo(PHONE_FAX_WHOLE_NUMBER, ASCIIToUTF16("1915240000"));
Time pre_modification_time_2 = Time::Now();
EXPECT_TRUE(db.GetAutofillTable()->UpdateAutofillProfileMulti(
billing_profile));
@@ -828,47 +826,6 @@ TEST_F(AutofillTableTest, AutofillProfileMultiValuePhone) {
delete db_profile;
}
-TEST_F(AutofillTableTest, AutofillProfileMultiValueFax) {
- WebDatabase db;
- ASSERT_EQ(sql::INIT_OK, db.Init(file_));
-
- AutofillProfile p;
- const string16 kJohnDoe(ASCIIToUTF16("4151112222"));
- const string16 kJohnPDoe(ASCIIToUTF16("4151113333"));
- std::vector<string16> set_values;
- set_values.push_back(kJohnDoe);
- set_values.push_back(kJohnPDoe);
- p.SetMultiInfo(PHONE_FAX_WHOLE_NUMBER, set_values);
-
- EXPECT_TRUE(db.GetAutofillTable()->AddAutofillProfile(p));
-
- AutofillProfile* db_profile;
- ASSERT_TRUE(db.GetAutofillTable()->GetAutofillProfile(p.guid(), &db_profile));
- EXPECT_EQ(p, *db_profile);
- EXPECT_EQ(0, p.CompareMulti(*db_profile));
- delete db_profile;
-
- // Update the values.
- const string16 kNoOne(ASCIIToUTF16("4151110000"));
- set_values[1] = kNoOne;
- p.SetMultiInfo(PHONE_FAX_WHOLE_NUMBER, set_values);
- EXPECT_TRUE(db.GetAutofillTable()->UpdateAutofillProfileMulti(p));
- ASSERT_TRUE(db.GetAutofillTable()->GetAutofillProfile(p.guid(), &db_profile));
- EXPECT_EQ(p, *db_profile);
- EXPECT_EQ(0, p.CompareMulti(*db_profile));
- delete db_profile;
-
- // Delete values.
- set_values.clear();
- p.SetMultiInfo(PHONE_FAX_WHOLE_NUMBER, set_values);
- EXPECT_TRUE(db.GetAutofillTable()->UpdateAutofillProfileMulti(p));
- ASSERT_TRUE(db.GetAutofillTable()->GetAutofillProfile(p.guid(), &db_profile));
- EXPECT_EQ(p, *db_profile);
- EXPECT_EQ(0, p.CompareMulti(*db_profile));
- EXPECT_EQ(string16(), db_profile->GetInfo(EMAIL_ADDRESS));
- delete db_profile;
-}
-
TEST_F(AutofillTableTest, AutofillProfileTrash) {
WebDatabase db;
@@ -1071,7 +1028,6 @@ TEST_F(AutofillTableTest, UpdateAutofillProfile) {
profile.SetInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("90025"));
profile.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"));
profile.SetInfo(PHONE_HOME_WHOLE_NUMBER, ASCIIToUTF16("18181234567"));
- profile.SetInfo(PHONE_FAX_WHOLE_NUMBER, ASCIIToUTF16("1915243678"));
db.GetAutofillTable()->AddAutofillProfile(profile);
// Set a mocked value for the profile's creation time.
« no previous file with comments | « chrome/browser/webdata/autofill_table.cc ('k') | chrome/browser/webdata/web_database_migration_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698