Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/autofill/autofill_type.cc

Issue 7892048: Autofill: Remove fax number completely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment fix. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_type.h ('k') | chrome/browser/autofill/fax_number.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_type.cc
diff --git a/chrome/browser/autofill/autofill_type.cc b/chrome/browser/autofill/autofill_type.cc
index b53d997f9956cda2af5d8cf652ffd29d63666582..8aefd1c91807a3910429d1b172a0647cc905a368 100644
--- a/chrome/browser/autofill/autofill_type.cc
+++ b/chrome/browser/autofill/autofill_type.cc
@@ -52,16 +52,12 @@ AutofillType::AutofillTypeDefinition kAutofillTypeDefinitions[] = {
{ AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
{ AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
- // PHONE_FAX_NUMBER
- { AutofillType::PHONE_FAX, AutofillType::PHONE_NUMBER },
- // PHONE_FAX_CITY_CODE
- { AutofillType::PHONE_FAX, AutofillType::PHONE_CITY_CODE },
- // PHONE_FAX_COUNTRY_CODE
- { AutofillType::PHONE_FAX, AutofillType::PHONE_COUNTRY_CODE },
- // PHONE_FAX_CITY_AND_NUMBER
- { AutofillType::PHONE_FAX, AutofillType::PHONE_CITY_AND_NUMBER },
- // PHONE_FAX_WHOLE_NUMBER
- { AutofillType::PHONE_FAX, AutofillType::PHONE_WHOLE_NUMBER },
+ // Fax numbers (values [20,24]) are deprecated.
+ { AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
+ { AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
+ { AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
+ { AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
+ { AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
// Cell phone numbers (values [25, 29]) are deprecated.
{ AutofillType::NO_GROUP, AutofillType::NO_SUBGROUP },
@@ -231,16 +227,6 @@ std::string AutofillType::FieldTypeToString(AutofillFieldType type) {
return "PHONE_HOME_CITY_AND_NUMBER";
case PHONE_HOME_WHOLE_NUMBER:
return "PHONE_HOME_WHOLE_NUMBER";
- case PHONE_FAX_NUMBER:
- return "PHONE_FAX_NUMBER";
- case PHONE_FAX_CITY_CODE:
- return "PHONE_FAX_CITY_CODE";
- case PHONE_FAX_COUNTRY_CODE:
- return "PHONE_FAX_COUNTRY_CODE";
- case PHONE_FAX_CITY_AND_NUMBER:
- return "PHONE_FAX_CITY_AND_NUMBER";
- case PHONE_FAX_WHOLE_NUMBER:
- return "PHONE_FAX_WHOLE_NUMBER";
case ADDRESS_HOME_LINE1:
return "ADDRESS_HOME_LINE1";
case ADDRESS_HOME_LINE2:
@@ -327,16 +313,6 @@ AutofillFieldType AutofillType::StringToFieldType(const std::string& str) {
return PHONE_HOME_CITY_AND_NUMBER;
if (str == "PHONE_HOME_WHOLE_NUMBER")
return PHONE_HOME_WHOLE_NUMBER;
- if (str == "PHONE_FAX_NUMBER")
- return PHONE_FAX_NUMBER;
- if (str == "PHONE_FAX_CITY_CODE")
- return PHONE_FAX_CITY_CODE;
- if (str == "PHONE_FAX_COUNTRY_CODE")
- return PHONE_FAX_COUNTRY_CODE;
- if (str == "PHONE_FAX_CITY_AND_NUMBER")
- return PHONE_FAX_CITY_AND_NUMBER;
- if (str == "PHONE_FAX_WHOLE_NUMBER")
- return PHONE_FAX_WHOLE_NUMBER;
if (str == "ADDRESS_HOME_LINE1")
return ADDRESS_HOME_LINE1;
if (str == "ADDRESS_HOME_LINE2")
« no previous file with comments | « chrome/browser/autofill/autofill_type.h ('k') | chrome/browser/autofill/fax_number.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698