Autofill: Remove fax number completely.

chrome/browser/autofill/phone_number_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/phone_number.h"
 #include "chrome/browser/autofill/phone_number_i18n.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(PhoneNumberTest, Matcher) {
   AutofillProfile profile;
   profile.SetCountryCode("US");
   // Set phone number so country_code == 1, city_code = 650, number = 2345678.
   string16 phone(ASCIIToUTF16("1 [650] 234-5678"));
-  PhoneNumber phone_number(AutofillType::PHONE_HOME, &profile);
+  PhoneNumber phone_number(&profile);
   phone_number.SetInfo(PHONE_HOME_WHOLE_NUMBER, phone);
   phone_number.NormalizePhone();
 
   FieldTypeSet matching_types;
   phone_number.GetMatchingTypes(ASCIIToUTF16(""), &matching_types);
   EXPECT_EQ(1U, matching_types.size());
   EXPECT_TRUE(matching_types.find(EMPTY_TYPE) != matching_types.end());
   matching_types.clear();
   phone_number.GetMatchingTypes(ASCIIToUTF16("1"), &matching_types);
   EXPECT_EQ(1U, matching_types.size());
@@ skipping 40 matching lines @@
   matching_types.clear();
   phone_number.GetMatchingTypes(ASCIIToUTF16("6502345678"), &matching_types);
   EXPECT_EQ(1U, matching_types.size());
   EXPECT_TRUE(matching_types.find(PHONE_HOME_CITY_AND_NUMBER) !=
               matching_types.end());
   matching_types.clear();
   phone_number.GetMatchingTypes(ASCIIToUTF16("(650)2345678"), &matching_types);
   EXPECT_EQ(1U, matching_types.size());
   EXPECT_TRUE(matching_types.find(PHONE_HOME_CITY_AND_NUMBER) !=
               matching_types.end());
-
-  string16 fax(ASCIIToUTF16("+1(650)650-5678"));
-  PhoneNumber fax_number(&profile);
-  fax_number.SetInfo(PHONE_FAX_WHOLE_NUMBER, fax);
-
-  matching_types.clear();
-  fax_number.GetMatchingTypes(ASCIIToUTF16("16506505678"), &matching_types);
-  EXPECT_EQ(1U, matching_types.size());
-  EXPECT_TRUE(matching_types.find(PHONE_FAX_WHOLE_NUMBER) !=
-              matching_types.end());
-
-  matching_types.clear();
-  fax_number.GetMatchingTypes(ASCIIToUTF16("650"), &matching_types);
-  EXPECT_EQ(2U, matching_types.size());
-  EXPECT_TRUE(matching_types.find(PHONE_FAX_CITY_CODE) !=
-              matching_types.end());
-  EXPECT_TRUE(matching_types.find(PHONE_FAX_NUMBER) !=
-              matching_types.end());
 }
 
 TEST(PhoneNumberTest, PhoneCombineHelper) {
-  PhoneNumber::PhoneCombineHelper number1(AutofillType::PHONE_HOME);
+  PhoneNumber::PhoneCombineHelper number1;
   EXPECT_FALSE(number1.SetInfo(ADDRESS_BILLING_CITY,
                                ASCIIToUTF16("1")));
-  EXPECT_FALSE(number1.SetInfo(PHONE_FAX_COUNTRY_CODE,
-                               ASCIIToUTF16("1")));
   EXPECT_TRUE(number1.SetInfo(PHONE_HOME_COUNTRY_CODE,
                               ASCIIToUTF16("1")));
   EXPECT_TRUE(number1.SetInfo(PHONE_HOME_CITY_CODE,
                               ASCIIToUTF16("650")));
   EXPECT_TRUE(number1.SetInfo(PHONE_HOME_NUMBER,
                               ASCIIToUTF16("2345678")));
   string16 parsed_phone;
   EXPECT_TRUE(number1.ParseNumber("US", &parsed_phone));
   // International format as it has a country code.
   EXPECT_EQ(ASCIIToUTF16("+1 650-234-5678"), parsed_phone);
 
-  PhoneNumber::PhoneCombineHelper number2(AutofillType::PHONE_FAX);
-  EXPECT_FALSE(number2.SetInfo(PHONE_HOME_COUNTRY_CODE,
-                               ASCIIToUTF16("1")));
-  EXPECT_TRUE(number2.SetInfo(PHONE_FAX_COUNTRY_CODE,
-                              ASCIIToUTF16("1")));
-  EXPECT_TRUE(number2.SetInfo(PHONE_FAX_CITY_CODE,
-                              ASCIIToUTF16("650")));
-  EXPECT_TRUE(number2.SetInfo(PHONE_FAX_NUMBER,
-                              ASCIIToUTF16("2345679")));
-  EXPECT_TRUE(number2.ParseNumber("US", &parsed_phone));
-  // International format as it has a country code.
-  EXPECT_EQ(ASCIIToUTF16("+1 650-234-5679"), parsed_phone);
-
-  PhoneNumber::PhoneCombineHelper number3(AutofillType::PHONE_HOME);
+  PhoneNumber::PhoneCombineHelper number3;
   EXPECT_TRUE(number3.SetInfo(PHONE_HOME_CITY_CODE,
                               ASCIIToUTF16("650")));
   EXPECT_TRUE(number3.SetInfo(PHONE_HOME_NUMBER,
                               ASCIIToUTF16("2345680")));
   EXPECT_TRUE(number3.ParseNumber("US", &parsed_phone));
   // National format as it does not have a country code.
   EXPECT_EQ(ASCIIToUTF16("(650) 234-5680"), parsed_phone);
 
-  PhoneNumber::PhoneCombineHelper number4(AutofillType::PHONE_HOME);
+  PhoneNumber::PhoneCombineHelper number4;
   EXPECT_TRUE(number4.SetInfo(PHONE_HOME_CITY_CODE,
                               ASCIIToUTF16("123")));  // Incorrect city code.
   EXPECT_TRUE(number4.SetInfo(PHONE_HOME_NUMBER,
                               ASCIIToUTF16("2345680")));
   EXPECT_FALSE(number4.ParseNumber("US", &parsed_phone));
   EXPECT_EQ(string16(), parsed_phone);
 
-  PhoneNumber::PhoneCombineHelper number5(AutofillType::PHONE_HOME);
+  PhoneNumber::PhoneCombineHelper number5;
   EXPECT_TRUE(number5.SetInfo(PHONE_HOME_CITY_AND_NUMBER,
                               ASCIIToUTF16("6502345681")));
   EXPECT_TRUE(number5.ParseNumber("US", &parsed_phone));
   EXPECT_EQ(ASCIIToUTF16("(650) 234-5681"), parsed_phone);
 
-  PhoneNumber::PhoneCombineHelper number6(AutofillType::PHONE_HOME);
+  PhoneNumber::PhoneCombineHelper number6;
   EXPECT_TRUE(number6.SetInfo(PHONE_HOME_CITY_CODE,
                               ASCIIToUTF16("650")));
   EXPECT_TRUE(number6.SetInfo(PHONE_HOME_NUMBER,
                               ASCIIToUTF16("234")));
   EXPECT_TRUE(number6.SetInfo(PHONE_HOME_NUMBER,
                               ASCIIToUTF16("5682")));
   EXPECT_TRUE(number6.ParseNumber("US", &parsed_phone));
   EXPECT_EQ(ASCIIToUTF16("(650) 234-5682"), parsed_phone);
 }