Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 789163006: Add toString methods to SkImageFilter-derived classes (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add toString methods to SkImageFilter-derived classes This isn't definitive but at least makes something show up in the debugger. Committed: https://skia.googlesource.com/skia/+/f3f5bad7ded35265c0b5d042cc4174386b197a33

Patch Set 1 #

Patch Set 2 : Fill in a bit more #

Patch Set 3 : Make sure leading 0's aren't stripped off colors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -3 lines) Patch
M gm/imagefiltersbase.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkBitmapSource.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkComposeImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 2 chunks +6 lines, -1 line 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkMatrixImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/effects/SkBitmapSource.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 4 chunks +18 lines, -0 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/effects/SkMatrixImageFilter.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +26 lines, -1 line 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years ago (2014-12-19 20:02:30 UTC) #2
reed1
lgtm
6 years ago (2014-12-19 21:33:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789163006/40001
6 years ago (2014-12-19 21:40:10 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-19 21:49:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f3f5bad7ded35265c0b5d042cc4174386b197a33

Powered by Google App Engine
This is Rietveld 408576698