Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 789153004: Fix Chromoting under Ozone. (Closed)

Created:
6 years ago by kpschoedel
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ppapi key codes under Ozone. Moves the native-event test from RenderWidgetHostViewAura::OnKeyEvent() down to MakeWebKeyboardEvent() so that nativeKeyCode is correctly set. Symptoms included incorrect characters in Chromoting, and Search key not working in non-web windows. BUG=425156 BUG=440184 Committed: https://crrev.com/6c3cc33ee385dd026ca3e8d77032e38702f137f3 Cr-Commit-Position: refs/heads/master@{#307994}

Patch Set 1 #

Patch Set 2 : #include fix for Windows build #

Patch Set 3 : unit test #

Total comments: 1

Patch Set 4 : DISALLOW_COPY_AND_ASSIGN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -25 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +2 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 3 chunks +31 lines, -0 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 4 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kpschoedel
6 years ago (2014-12-10 17:02:41 UTC) #2
sadrul
Can you add a test?
6 years ago (2014-12-11 15:16:48 UTC) #3
kpschoedel
Test without this patch shown failing here: https://codereview.chromium.org/791413002/
6 years ago (2014-12-11 19:19:13 UTC) #4
sadrul
Thanks! LGTM https://codereview.chromium.org/789153004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc File content/browser/renderer_host/render_widget_host_view_aura_unittest.cc (right): https://codereview.chromium.org/789153004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc#newcode146 content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:146: scoped_ptr<NativeWebKeyboardEvent> last_event_; DISALLOW_COPY_...
6 years ago (2014-12-11 19:20:57 UTC) #5
kpschoedel
6 years ago (2014-12-11 19:24:20 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-11 23:12:27 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-11 23:13:14 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6c3cc33ee385dd026ca3e8d77032e38702f137f3
Cr-Commit-Position: refs/heads/master@{#307994}

Powered by Google App Engine
This is Rietveld 408576698