Land Recent QUIC Changes.

Land Recent QUIC Changes.

Refactoring of some QUIC code for readability.

Merge internal change: 83493327
https://codereview.chromium.org/848513002/

Squelch a variety of "GMOCK WARNING" messages in quic_session_test by
using a StrictMock, and adding the necessary EXPECT_CALL()s.

Merge internal change: 83469149
https://codereview.chromium.org/842223006/

Attach QuicAckNotifiers to the serialized packet, instead of individual
stream frames.

Protected behind FLAGS_quic_attach_ack_notifiers_to_packets.

A call to QuicPacketGenerator::ConsumeData may result in multiple stream
frames, in multiple packets, being created to hold the data. Previously
the QuicAckNotifier was attached to each *frame*, but really it should
be attached to the serialized *packet* as the notifier is interested in
knowing when the *packet* gets ACKed.

No behavior change intended.

Added an end to end test demonstrating that the AckNotifier works in the
face of 30% packet loss. Earlier rch and I were sceptical this refactor
would work with retransmissions, but the QuicAckNotifierManager still
recieves calls to UpdateSequenceNumber and does the right thing.

Merge internal change: 83452063
https://codereview.chromium.org/819653006/

Removing deprecated flag FLAGS_allow_truncated_connection_ids_for_quic

Merge internal change: 83439062
https://codereview.chromium.org/843213002/

R=rch@chromium.org

Committed: https://crrev.com/6b1c5b19293367a7f00bf3b1a5507e51b1d73720
Cr-Commit-Position: refs/heads/master@{#311316}

[ramant (doing other things), 2015-01-13 03:29:24]

Hi Ryan,
  This CL includes all the changes you have approved. This CL doesn't have
cleanup changes found during merge.

  Would like to submit quic_client_bin changes separately (because it required
chrome side implementation).

  Many many thanks for your patience with reviewing all these changes.

-raman

[Ryan Hamilton, 2015-01-13 18:46:47]

lgtm

[ramant (doing other things), 2015-01-13 18:54:07]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2015-01-13 18:54:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789103013/1

[commit-bot: I haz the power, 2015-01-13 20:09:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-13 20:09:55]

Patchset 1 (id:??) landed as
https://crrev.com/6b1c5b19293367a7f00bf3b1a5507e51b1d73720
Cr-Commit-Position: refs/heads/master@{#311316}