Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 7891013: Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary (Closed)

Created:
8 years, 11 months ago by adamk
Modified:
8 years, 11 months ago
Reviewers:
adamk
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary https://bugs.webkit.org/show_bug.cgi?id=67958 Reviewed by Darin Adler. Reported by Valgrind in http://crbug.com/77049. The errant code was added as an optimization in r67804. This patch reverts that one, as all parties agree that the optimization doesn't seem worthwhile, and there clearly aren't any tests covering the special case. No new tests, as existing tests should cover the remaining call to |std::stable_sort|. * platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): TBR=adamk@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/WebCore/platform/graphics/Gradient.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
adamk
8 years, 11 months ago (2011-09-13 17:56:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698