Implement clipboardRead/Write content capabilities

extensions/renderer/script_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "extensions/common/features/feature.h"
+#include "extensions/common/permissions/api_permission_set.h"
 #include "extensions/renderer/module_system.h"
 #include "extensions/renderer/request_sender.h"
 #include "extensions/renderer/safe_builtins.h"
 #include "extensions/renderer/scoped_persistent.h"
 #include "gin/runner.h"
 #include "url/gurl.h"
 #include "v8/include/v8.h"
 
 namespace blink {
 class WebFrame;
@@ skipping 120 matching lines @@
 
   // gin::Runner overrides.
   void Run(const std::string& source,
            const std::string& resource_name) override;
   v8::Handle<v8::Value> Call(v8::Handle<v8::Function> function,
                              v8::Handle<v8::Value> receiver,
                              int argc,
                              v8::Handle<v8::Value> argv[]) override;
   gin::ContextHolder* GetContextHolder() override;
 
+  // Grants a set of content capabilities to this context.
+  void SetContentCapabilities(const APIPermissionSet& permissions);
+
+  // Indicates if this context has an effective API permission either by being
+  // a context for an extension which has that permission, or by being a web
+  // context which has been granted the corresponding capability by an
+  // extension.
+  bool HasEffectiveAPIPermission(APIPermission::ID permission) const;

[not at google - send to devlin, 2014/12/10 17:33:54]

What is "Effective" about this?

Ideally we'd call this HasAPIPermission and do all permission checks here (both
for the Extension, if it exists, and the content capabilities if this exists).

In fact, what would it take to include the content capability check in
IsAnyFeatureAvailableToContext? (probably too much; terribly specific function).

In lieu of all that, since the implementation only checks content capabilities,
so I'd call this HasContentCapability.

[Ken Rockot(use gerrit already), 2014/12/10 18:31:41]

Heh, that's what it was and then I changed it mostly to preserve the original
terminology of the code which consumes it (i.e. essentially
effective_extension->has_permission)

But really I like this better, so SGTM and Done.

+
  protected:
   // The v8 context the bindings are accessible to.
   ScopedPersistent<v8::Context> v8_context_;
 
  private:
   // The WebFrame associated with this context. This can be NULL because this
   // object can outlive is destroyed asynchronously.
   blink::WebFrame* web_frame_;
 
   // The extension associated with this context, or NULL if there is none. This
@@ skipping 10 matching lines @@
 
   // The type of context.
   Feature::Context effective_context_type_;
 
   // Owns and structures the JS that is injected to set up extension bindings.
   scoped_ptr<ModuleSystem> module_system_;
 
   // Contains safe copies of builtin objects like Function.prototype.
   SafeBuiltins safe_builtins_;
 
+  // The set of capabilities granted to this context by extensions.
+  APIPermissionSet content_capabilities_;
+
   v8::Isolate* isolate_;
 
   GURL url_;
 
   DISALLOW_COPY_AND_ASSIGN(ScriptContext);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_