Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 78903006: upload again, rietveld diff failed. (Closed)

Created:
7 years, 1 month ago by bsalomon
Modified:
7 years, 1 month ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix VC++ ptr-to-... and va_list confusion R=bungeman@google.com Committed: http://code.google.com/p/skia/source/detail?r=12346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/core/SkString.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkString.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
7 years, 1 month ago (2013-11-21 16:52:11 UTC) #1
bungeman-skia
lgtm
7 years, 1 month ago (2013-11-21 17:02:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/78903006/1
7 years, 1 month ago (2013-11-21 17:03:38 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 17:20:19 UTC) #4
Message was sent while issue was closed.
Change committed as 12346

Powered by Google App Engine
This is Rietveld 408576698