Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 78903003: Added a new overload of gfx::Image::CreateFrom1xPNGBytes (Closed)

Created:
7 years, 1 month ago by João Eiras
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsesek+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added a new overload of gfx::Image::CreateFrom1xPNGBytes ... that accepts a RefCountedMemory. This saves some buffer copying in many places, specially welcome with big images. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243492

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M chrome/browser/android/favicon_helper.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/icon_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/image/image.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +10 lines, -1 line 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nicolas Zea
sync LGTM
7 years ago (2013-12-02 21:04:37 UTC) #1
rpetterson
profiles LGTM
7 years ago (2013-12-04 05:39:11 UTC) #2
João Eiras
Hi! This review has been open for 6 weeks now. Could someone please help review ...
6 years, 11 months ago (2014-01-07 14:47:14 UTC) #3
newt (away)
android lgtm
6 years, 11 months ago (2014-01-07 15:04:10 UTC) #4
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-07 17:03:11 UTC) #5
sky
What files do you need me to review? I suspect Ben's approval covers it all. ...
6 years, 11 months ago (2014-01-07 17:18:54 UTC) #6
João Eiras
Ben's review covered what was missing. Thank you!
6 years, 11 months ago (2014-01-07 17:44:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/78903003/30001
6 years, 11 months ago (2014-01-07 17:44:52 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242590
6 years, 11 months ago (2014-01-07 20:18:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaoe@opera.com/78903003/30001
6 years, 11 months ago (2014-01-08 01:44:20 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 06:15:08 UTC) #11
Message was sent while issue was closed.
Change committed as 243492

Powered by Google App Engine
This is Rietveld 408576698