Observe OnExtensionLoaded to trigger update of chrome.commands keybindings for component extensions.

chrome/browser/extensions/api/commands/command_service.cc

Index: chrome/browser/extensions/api/commands/command_service.cc
diff --git a/chrome/browser/extensions/api/commands/command_service.cc b/chrome/browser/extensions/api/commands/command_service.cc
index 33a522e04104bb5816b4e2fcae386448c0a9715d..d2dafc1305973f84f7fd7f84d3735817825cd695 100644
--- a/chrome/browser/extensions/api/commands/command_service.cc
+++ b/chrome/browser/extensions/api/commands/command_service.cc
@@ -294,19 +294,15 @@ bool CommandService::AddKeybindingPref(
   return true;
 }
 
-void CommandService::OnExtensionWillBeInstalled(
-    content::BrowserContext* browser_context,
-    const Extension* extension,
-    bool is_update,
-    bool from_ephemeral,
-    const std::string& old_name) {
+void CommandService::OnExtensionLoaded(content::BrowserContext* browser_context,
+                                       const Extension* extension) {
   UpdateKeybindings(extension);
 }
 
-void CommandService::OnExtensionUninstalled(
+void CommandService::OnExtensionUnloaded(
     content::BrowserContext* browser_context,
     const Extension* extension,
-    extensions::UninstallReason reason) {
+    UnloadedExtensionInfo::Reason reason) {
   RemoveKeybindingPrefs(extension->id(), std::string());

[Finnur, 2014/12/10 12:25:38]

If I temporarily disable an extension/it crashes, won't that 
unregister the keybinding? What if a new extension is then installed, which
overlaps in keybindings. Who wins if the initial extension gets re-enabled?

What happens if I install extension A and B, which request the same keybinding
and start toggling them enabled/disabled. Will keybindings change as a result?

Should we perhaps listen to both sets of series (Load-Unload vs.
Install-Uninstall) and act on Load/Unload only for Component Extensions, because
those won't be "toggle-able"?

[David Tseng, 2014/12/10 17:27:51]

Done.
Yup; that's the right way to do this; had only tested with component extensions.
Install does get called when the component extension gets loaded into a new
profile, so we need to qualify on Manifest::COMPONENT. in all OnExtension*.

 }