Issue 788953007: Populate details of Mojo gesture events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 788953007: Populate details of Mojo gesture events (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
Elliot Glaysher

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Populate details of Mojo gesture events We compute these details in the gesture recognizer, but previously we weren't including this information in the actual mojo::Event. This CL also decodes this information into WebInputEvents for Sky. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3a7472de4a0b4711c675d5c892b336b953bd4ff0

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -2 lines)			Patch
M	mojo/converters/input_events/input_events_type_converters.cc	View	1 chunk	+30 lines, -2 lines	0 comments	Download
M	mojo/services/input_events/public/interfaces/input_events.mojom	View	2 chunks	+26 lines, -0 lines	0 comments	Download
M	sky/viewer/converters/input_event_types.cc	View	4 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 11 months ago (2015-01-16 19:04:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3a7472de4a0b4711c675d5c892b336b953bd4ff0 (presubmit successful).

Expand Messages | Collapse Messages