Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 788953006: Fix <sky-input> data binding when editing deletes the last char. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix <sky-input> data binding when editing deletes the last char. contenteditable would remove the Text node inside the editable area which would mean setting the value attr of the <sky-input> would stop updating the editable area. Instead we add the text back if editing removed it. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7387509e1fd934812a3ef1bd1829bc9a0b3022ce

Patch Set 1 #

Patch Set 2 : avoid two change events. #

Patch Set 3 : avoid two change events. #

Patch Set 4 : no really. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M sky/framework/sky-input.sky View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
esprehn
5 years, 11 months ago (2015-01-16 07:07:28 UTC) #1
abarth-chromium
Test? LGTM
5 years, 11 months ago (2015-01-16 07:11:01 UTC) #3
esprehn
On 2015/01/16 at 07:11:01, abarth wrote: > Test? > > LGTM Yeah testing this requires ...
5 years, 11 months ago (2015-01-16 07:12:54 UTC) #4
abarth-chromium
On 2015/01/16 at 07:12:54, esprehn wrote: > On 2015/01/16 at 07:11:01, abarth wrote: > > ...
5 years, 11 months ago (2015-01-16 07:13:46 UTC) #5
esprehn
5 years, 11 months ago (2015-01-16 22:39:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7387509e1fd934812a3ef1bd1829bc9a0b3022ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698