Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 788953005: cros: Add a11y to enable debugging screen. (Closed)

Created:
5 years, 11 months ago by xiyuan
Modified:
5 years, 11 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Add a11y to enable debugging screen. - Fix defaultControl to return ok button for error screen; - Add aria-live and aria-atomic to content div so that it is read out when the screen state is changed and all contents are updated; BUG=413766 TEST=Test enable-debugging flow with ChromeVox and verify that title and message gets read on each step. Committed: https://crrev.com/a63b2ff95caa18852ef3448db213ee730cbd6bab Cr-Commit-Position: refs/heads/master@{#311542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_enable_debugging.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
xiyuan
David, could you help with the review? Thanks.
5 years, 11 months ago (2015-01-13 21:20:27 UTC) #2
David Tseng
lgtm nit: please add a TEST= line (e.g. tested with ChromeVox; verified the enabled debugging ...
5 years, 11 months ago (2015-01-14 19:16:04 UTC) #3
xiyuan
On 2015/01/14 19:16:04, David Tseng wrote: > lgtm > > nit: please add a TEST= ...
5 years, 11 months ago (2015-01-14 19:20:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788953005/1
5 years, 11 months ago (2015-01-14 19:21:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 20:52:24 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 20:53:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a63b2ff95caa18852ef3448db213ee730cbd6bab
Cr-Commit-Position: refs/heads/master@{#311542}

Powered by Google App Engine
This is Rietveld 408576698