Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 788943003: Make SkyElement more classy. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
rafaelw, ojan
CC:
abarth-chromium, eseidel, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make SkyElement more classy. The syntax for implementing a SkyElement is now: <sky-element name="element-name"> <template> <!-- template here --> </template> <script> module.exports = class extends SkyElement { attached() { // ... } // .. methods here .. }.register(); </script> </sky-element> The register() static method on SkyElement subclasses calls document.registerElement() and returns the generated constructor. It uses the parent <sky-element>'s name attribute to set the name of the element. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1d1dd2b46936dadb4277671d13b6ee7ff6d6234

Patch Set 1 #

Patch Set 2 : Don't change indent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -124 lines) Patch
M sky/examples/city-list/city-list.sky View 1 7 chunks +45 lines, -40 lines 0 comments Download
M sky/examples/file-browser.sky View 3 chunks +10 lines, -7 lines 0 comments Download
M sky/examples/flights-app/app-header.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-menu-button.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-panel.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-panel-content.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-panel-header.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-scrollable.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-search-input.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-title.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-toast.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/app-toolbar.sky View 2 chunks +5 lines, -3 lines 0 comments Download
M sky/examples/flights-app/flights-app.sky View 2 chunks +4 lines, -3 lines 0 comments Download
M sky/examples/flights-app/index.sky View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 2 chunks +40 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
This can't land yet because of https://code.google.com/p/v8/issues/detail?id=3750 but it shows the syntax change. After thinking ...
6 years ago (2014-12-09 22:13:34 UTC) #2
rafaelw
lgtm
6 years ago (2014-12-10 03:30:55 UTC) #3
esprehn
6 years ago (2014-12-17 00:28:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c1d1dd2b46936dadb4277671d13b6ee7ff6d6234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698