Let `git cl format` format java files, too.

Let `git cl format` format java files, too.

This will only have an effect if one's buildtools checkout is new enough, since
only then:

a) clang-format will be new enough to do a decent job for java files
b) clang-format-diff.py will be new enough to look at java files

So for older buildtools checkouts, `git cl format` will continue to ignore java
files.  For newer buildtools checkouts (like the one pulled by `gclient sync`
with a recent chromium checkout), it'll work and do a fairly decent job.

BUG=429372
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293312

[Nico, 2014-12-09 20:12:46]

thakis@chromium.org changed reviewers:
+ iannucci@chromium.org

[Nico, 2014-12-09 20:12:46]

I'll send out a short heads-up to chromium-dev once this is in.

[M-A Ruel, 2014-12-09 21:15:44]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2014-12-09 21:15:45]

https://codereview.chromium.org/788933003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/788933003/diff/1/git_cl.py#newcode2772
git_cl.py:2772: CLANG_EXTS = ['.cc', '.cpp', '.h', '.mm', '.proto', '.java']
A careful reader will note that the list was sorted.

[Nico, 2014-12-09 21:17:44]

https://codereview.chromium.org/788933003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/788933003/diff/1/git_cl.py#newcode2772
git_cl.py:2772: CLANG_EXTS = ['.cc', '.cpp', '.h', '.mm', '.proto', '.java']
On 2014/12/09 21:15:45, M-A Ruel wrote:
> A careful reader will note that the list was sorted.

It’s not sorted, it’s grouped by language. See the similar list in
https://github.com/chapuni/clang/blob/master/tools/clang-format/clang-format-...
, it just looks sorted by accident.

[M-A Ruel, 2014-12-09 21:18:35]

https://codereview.chromium.org/788933003/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/788933003/diff/1/git_cl.py#newcode2772
git_cl.py:2772: CLANG_EXTS = ['.cc', '.cpp', '.h', '.mm', '.proto', '.java']
On 2014/12/09 21:17:44, Nico wrote:
> On 2014/12/09 21:15:45, M-A Ruel wrote:
> > A careful reader will note that the list was sorted.
> 
> It’s not sorted, it’s grouped by language. See the similar list in
>
https://github.com/chapuni/clang/blob/master/tools/clang-format/clang-format-...
> , it just looks sorted by accident.

"..."

lgtm

[Nico, 2014-12-09 21:19:17]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-12-09 21:19:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788933003/1

[commit-bot: I haz the power, 2014-12-09 21:21:54]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293312