Extract unit tests from the mixed bag process_util_unittest.cc into proper files.

Extract unit tests from the mixed bag process_util_unittest.cc into proper files.

It is a first step of multiple CLs.

Rename process_metrics_unittests.cc to process_metrics_unittest.cc to be
consistent with the rest of the project.

Rename process_util_unittest_ios.cc to process_metrics_unittest_ios.cc since it
is just about process_metrics.h.

Extract a few process_metrics.h specific unit tests from
process_util_unittest.cc into process_metrics_unittest.cc.

R=thakis@chromium.org
BUG=324546
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238009

[M-A Ruel, 2013-11-20 17:06:41]

I have a long standing CL to change process_iterator and the current mess makes
it really hard to rebase.

[Nico, 2013-11-21 00:19:25]

lgtm, but please remove the "Win" suffixes you added.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
File base/process/process_metrics_unittest.cc (right):

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
base/process/process_metrics_unittest.cc:274: }  // namespace base
Can you put the tests in debug::base? It looks weird to have half the tests in
this file in base::debug, but not the other half.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
base/process/process_metrics_unittest.cc:312: TEST(ProcessMetricsTest,
CalcFreeMemoryWin) {
We don't usually call tests that currently run only on one platform
TestPlatformname. I'd remove the trailing "Win"

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
File base/process/process_util_unittest.cc (right):

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
base/process/process_util_unittest.cc:358: TEST_F(ProcessUtilTest,
GetAppOutputWin) {
Why the test name change?

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
base/process/process_util_unittest.cc:388: TEST_F(ProcessUtilTest,
LaunchAsUserWin) {
Why the test name change?

[M-A Ruel, 2013-11-30 01:07:15]

Added bug. It's related to python upgrade. (I know it's far fetched but it's
true)

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
File base/process/process_metrics_unittest.cc (right):

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
base/process/process_metrics_unittest.cc:274: }  // namespace base
On 2013/11/21 00:19:26, Nico wrote:
> Can you put the tests in debug::base? It looks weird to have half the tests in
> this file in base::debug, but not the other half.

Done.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
base/process/process_metrics_unittest.cc:312: TEST(ProcessMetricsTest,
CalcFreeMemoryWin) {
On 2013/11/21 00:19:26, Nico wrote:
> We don't usually call tests that currently run only on one platform
> TestPlatformname. I'd remove the trailing "Win"

Done.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_met...
base/process/process_metrics_unittest.cc:312: TEST(ProcessMetricsTest,
CalcFreeMemoryWin) {
On 2013/11/21 00:19:26, Nico wrote:
> We don't usually call tests that currently run only on one platform
> TestPlatformname. I'd remove the trailing "Win"

Done.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
File base/process/process_util_unittest.cc (right):

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
base/process/process_util_unittest.cc:358: TEST_F(ProcessUtilTest,
GetAppOutputWin) {
On 2013/11/21 00:19:26, Nico wrote:
> Why the test name change?

Done.

https://codereview.chromium.org/78893002/diff/190001/base/process/process_uti...
base/process/process_util_unittest.cc:388: TEST_F(ProcessUtilTest,
LaunchAsUserWin) {
On 2013/11/21 00:19:26, Nico wrote:
> Why the test name change?

Sorry, fixed. I won't do again, I promise.

[commit-bot: I haz the power, 2013-11-30 01:07:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/78893002/290001

[commit-bot: I haz the power, 2013-11-30 05:46:50]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-02 00:04:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/78893002/290001

[commit-bot: I haz the power, 2013-12-02 01:01:04]

Change committed as 238009