Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 788923007: Layout test to verify pong message from the server. (Closed)

Created:
6 years ago by Adam Rice
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Layout test to verify pong message from the server. Issue crbug.com/443651 says that Chrome crashes on receiving pong messages with a payload. This does not appear to be true, but there is not an existing layout test testing this case, so add one. BUG=443651 TEST=layout tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187905

Patch Set 1 #

Total comments: 6

Patch Set 2 : Apply changes suggested by tyoshino. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
A LayoutTests/http/tests/websocket/receive-pong-with-payload.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/websocket/receive-pong-with-payload-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/http/tests/websocket/receive-pong-with-payload_wsh.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Adam Rice
6 years ago (2014-12-18 19:53:04 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/788923007/diff/1/LayoutTests/http/tests/websocket/pong-only.html File LayoutTests/http/tests/websocket/pong-only.html (right): https://codereview.chromium.org/788923007/diff/1/LayoutTests/http/tests/websocket/pong-only.html#newcode11 LayoutTests/http/tests/websocket/pong-only.html:11: var message; let's declare these variables right above each ...
5 years, 11 months ago (2015-01-05 05:19:45 UTC) #3
tyoshino (SeeGerritForStatus)
Let's give a file name that describes what the file does if possible than using ...
5 years, 11 months ago (2015-01-05 05:24:29 UTC) #4
Adam Rice
https://codereview.chromium.org/788923007/diff/1/LayoutTests/http/tests/websocket/pong-only.html File LayoutTests/http/tests/websocket/pong-only.html (right): https://codereview.chromium.org/788923007/diff/1/LayoutTests/http/tests/websocket/pong-only.html#newcode11 LayoutTests/http/tests/websocket/pong-only.html:11: var message; On 2015/01/05 05:19:45, tyoshino wrote: > let's ...
5 years, 11 months ago (2015-01-05 20:24:32 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm
5 years, 11 months ago (2015-01-06 03:03:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788923007/20001
5 years, 11 months ago (2015-01-06 09:13:05 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 09:16:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187905

Powered by Google App Engine
This is Rietveld 408576698