Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 788923003: Adding Link header support for dns-prefetch (Closed)

Created:
6 years ago by Yoav Weiss
Modified:
5 years, 10 months ago
Reviewers:
Pat Meenan, Mike West
CC:
blink-reviews, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding Link header support for dns-prefetch This CL hooks up the Link header parser with the existing dns-prefetch mechanism. The implementation is behind a turned-off-by-default flag. BUG=455648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189698

Patch Set 1 #

Patch Set 2 : Improved parser and added tests #

Patch Set 3 : Split out the parser #

Patch Set 4 : Added tests and a feature flag #

Patch Set 5 : Removed apache config #

Total comments: 2

Patch Set 6 : Rebased to use LinkHeaderSet. Added frame tests #

Patch Set 7 : Removed apache config. Again. #

Patch Set 8 : removed useless dumpAsText from frames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
A LayoutTests/http/tests/linkHeader/link-dnsprefetch-in-frame.html View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/linkHeader/link-dnsprefetch-in-frame-expected.txt View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/linkHeader/link-dnsprefetch-valid.php View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/linkHeader/link-dnsprefetch-valid-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/linkHeader/resources/link-dnsprefetch-frame.php View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/loader/LinkLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 2 3 4 5 2 chunks +23 lines, -1 line 0 comments Download
M Source/core/testing/InternalSettings.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yoav Weiss
5 years, 10 months ago (2015-02-05 20:56:04 UTC) #3
Mike West
LGTM % comments. https://codereview.chromium.org/788923003/diff/80001/Source/core/loader/DocumentLoader.cpp File Source/core/loader/DocumentLoader.cpp (right): https://codereview.chromium.org/788923003/diff/80001/Source/core/loader/DocumentLoader.cpp#newcode446 Source/core/loader/DocumentLoader.cpp:446: if (resource && resource->type() == Resource::MainResource) ...
5 years, 10 months ago (2015-02-06 12:22:06 UTC) #4
Yoav Weiss
On 2015/02/06 12:22:06, Mike West wrote: > LGTM % comments. > > https://codereview.chromium.org/788923003/diff/80001/Source/core/loader/DocumentLoader.cpp > File ...
5 years, 10 months ago (2015-02-06 14:20:27 UTC) #5
Yoav Weiss
> https://codereview.chromium.org/788923003/diff/80001/Source/core/loader/DocumentLoader.cpp#newcode446 > > Source/core/loader/DocumentLoader.cpp:446: if (resource && resource->type() == > > Resource::MainResource) > > ...
5 years, 10 months ago (2015-02-06 16:49:53 UTC) #7
Mike West
On 2015/02/06 at 16:49:53, yoav wrote: > > https://codereview.chromium.org/788923003/diff/80001/Source/core/loader/DocumentLoader.cpp#newcode446 > > > Source/core/loader/DocumentLoader.cpp:446: if (resource ...
5 years, 10 months ago (2015-02-06 16:59:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788923003/140001
5 years, 10 months ago (2015-02-06 17:05:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41771)
5 years, 10 months ago (2015-02-06 21:13:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788923003/140001
5 years, 10 months ago (2015-02-06 21:14:49 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 22:39:25 UTC) #15
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189698

Powered by Google App Engine
This is Rietveld 408576698