Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: content/common/input/touch_event_stream_validator_unittest.cc

Issue 788923002: Touch Events - changedTouches list includes non-changed touch points on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/input/touch_event_stream_validator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/input/touch_event_stream_validator_unittest.cc
diff --git a/content/common/input/touch_event_stream_validator_unittest.cc b/content/common/input/touch_event_stream_validator_unittest.cc
index 5e3b767fb1d09364de01342fc5736bc0e349ed71..fef7379ed1a2b0d911ce9036a2f7ac24161b88b5 100644
--- a/content/common/input/touch_event_stream_validator_unittest.cc
+++ b/content/common/input/touch_event_stream_validator_unittest.cc
@@ -159,7 +159,12 @@ TEST(TouchEventStreamValidator, InvalidPointStates) {
j <= WebTouchPoint::StateCancelled;
++j) {
event.touches[0].state = static_cast<WebTouchPoint::State>(j);
- if (event.touches[0].state == kValidTouchPointStatesForType[i]) {
+ if (event.touches[0].state == kValidTouchPointStatesForType[i]
+ // TODO(jdduke): Remove this StateStationary workaround check for
+ // TouchMove after implementing TouchMove events filtering based on
+ // corrected touches state in TouchEventQueue, crbug.com/452032.
+ || (event.type == WebInputEvent::TouchMove
+ && event.touches[0].state == WebTouchPoint::StateStationary)) {
EXPECT_TRUE(validator.Validate(event, &error_msg));
EXPECT_TRUE(error_msg.empty());
} else {
« no previous file with comments | « content/common/input/touch_event_stream_validator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698