content/common/input/touch_event_stream_validator.cc - Issue 788923002: Touch Events - changedTouches list includes non-changed touch points on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/touch_event_stream_validator.cc

Issue 788923002: Touch Events - changedTouches list includes non-changed touch points on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit test for checking Pointer states when other than position changed. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/input/synthetic_web_input_event_builders.h ('K') | « content/common/input/synthetic_web_input_event_builders.cc ('k') | content/common/input/touch_event_stream_validator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/touch_event_stream_validator.cc

diff --git a/content/common/input/touch_event_stream_validator.cc b/content/common/input/touch_event_stream_validator.cc

index 4c7598901dd2b1b145eeeaed55d014a5b956dc78..324e47a6ffa05db80032c9d30426605334c8bc77 100644

--- a/content/common/input/touch_event_stream_validator.cc

+++ b/content/common/input/touch_event_stream_validator.cc

@@ -139,6 +139,12 @@ bool TouchEventStreamValidator::Validate(const WebTouchEvent& event,

break;

case WebTouchPoint::StateStationary:

+ // TODO(jdduke): Remove this after implementing TouchMove events

+ // filtering based on corrected touches state in TouchEventQueue,

+ // crbug.com/452032.

+ if (event.type == WebInputEvent::TouchMove)

+ found_valid_state_for_type = true;

break;

case WebTouchPoint::StateCancelled: