Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 788903006: Remove legacy Picture defines. (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove legacy Picture defines. No longer needed by Android. Committed: https://skia.googlesource.com/skia/+/b64e56941c9e88490ffdaf825ee25f7d830c6350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -11 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scroggo
6 years ago (2014-12-19 14:56:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788903006/1
6 years ago (2014-12-19 14:56:55 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-19 14:56:56 UTC) #5
commit-bot: I haz the power
Presubmit check for 788903006-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-19 14:57:00 UTC) #7
reed1
lgtm
6 years ago (2014-12-19 15:17:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788903006/1
6 years ago (2014-12-19 15:19:34 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-19 15:28:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b64e56941c9e88490ffdaf825ee25f7d830c6350

Powered by Google App Engine
This is Rietveld 408576698