Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: sky/engine/core/dom/Document.cpp

Issue 788883005: Remove REM units. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Document.cpp
diff --git a/sky/engine/core/dom/Document.cpp b/sky/engine/core/dom/Document.cpp
index bef4928943c3693c11b0ba0ff570da3b855f2e1d..05f9916a1dda93b306de719687149ae434ea302c 100644
--- a/sky/engine/core/dom/Document.cpp
+++ b/sky/engine/core/dom/Document.cpp
@@ -1078,9 +1078,6 @@ void Document::updateRenderTree(StyleRecalcChange change)
// re-attaching our containing iframe, which when asked HTMLFrameElementBase::isURLAllowed
// hits a null-dereference due to security code always assuming the document has a SecurityOrigin.
- if (m_elemSheet && m_elemSheet->contents()->usesRemUnits())
- m_styleEngine->setUsesRemUnit(true);
-
updateStyle(change);
// As a result of the style recalculation, the currently hovered element might have been
@@ -1573,15 +1570,6 @@ void Document::updateBaseURL()
if (!m_baseURL.isValid())
m_baseURL = KURL();
-
- // FIXME(sky): remove?
- if (m_elemSheet) {
- // Element sheet is silly. It never contains anything.
- bool usesRemUnits = m_elemSheet->contents()->usesRemUnits();
- m_elemSheet = CSSStyleSheet::create(this, m_baseURL);
- // FIXME: So we are not really the parser. The right fix is to eliminate the element sheet completely.
- m_elemSheet->contents()->parserSetUsesRemUnits(usesRemUnits);
- }
}
void Document::didLoadAllImports()
« no previous file with comments | « sky/engine/core/css/resolver/StyleResolverState.cpp ('k') | sky/engine/core/dom/DocumentStyleSheetCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698