Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 788883005: Remove REM units. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove REM units. The code to make them dynamically update was already removed when Document::inheritHtmlAndBodyElementStyles was removed. We might want to add them back later, but probably in a different way, so lets remove the code for now to make refactoring the style system easier. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8bc9f42deba78706f8fb89b93e2a7b72951ec44c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -114 lines) Patch
M sky/engine/core/animation/DeferredLegacyStyleInterpolation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSCalculationValue.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSPrimitiveValue.h View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValue.cpp View 11 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/css/CSSToLengthConversionData.h View 2 chunks +1 line, -4 lines 0 comments Download
M sky/engine/core/css/CSSToLengthConversionData.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/css/MediaQueryExp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaValues.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/MediaValuesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/ElementResolveContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/ElementResolveContext.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolverState.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolverState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/TreeScopeStyleSheetCollection.cpp View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
6 years ago (2014-12-16 01:28:01 UTC) #2
esprehn
6 years ago (2014-12-16 01:29:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8bc9f42deba78706f8fb89b93e2a7b72951ec44c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698